OpenEXR writer was busted

Author: devsh

include/nbl/asset/interchange/IImageAssetHandlerBase.h

@@ -143,7 +143,7 @@ class IImageAssetHandlerBase : public virtual core::IReferenceCounted
 				};
 
 				// if texel block data does not need changing, we're good
-				if (identityTransform) // TODO: why do we even copy!?
+				if (identityTransform) // TODO: why do we even copy!? We should just STEAL the BUFFER DATA!
 				{
 					COPY_FILTER::state_type state;
 					fillCommonState(state);

src/nbl/asset/interchange/CImageWriterOpenEXR.cpp

@@ -148,7 +148,7 @@ bool createAndWriteImage(std::array<ilmType*, availableChannels>& pixelsArrayIlm
 
 	using StreamToEXR = CRegionBlockFunctorFilter<decltype(writeTexel), true>;
 	typename StreamToEXR::state_type state(writeTexel, image, nullptr);
-	for (auto region : image->getRegions())
+	for (const auto& region : image->getRegions())
 	{
 		if (region.imageSubresource.mipLevel || region.imageSubresource.baseArrayLayer)
 			continue;
@@ -194,16 +194,34 @@ bool CImageWriterOpenEXR::writeAsset(system::IFile* _file, const SAssetWritePara
 
 	SAssetWriteContext ctx{ _params, _file };
 
-	auto imageSmart = asset::IImageAssetHandlerBase::createImageDataForCommonWriting(IAsset::castDown<const ICPUImageView>(_params.rootAsset), _params.logger);
-	const asset::ICPUImage* image = imageSmart.get();
-	if (image->missingContent())
+	const ICPUImageView* imageView = IAsset::castDown<const ICPUImageView>(_params.rootAsset);
+	const auto& viewParams = imageView->getCreationParameters();
+	if (viewParams.image->missingContent())
 		return false;
 
-	system::IFile* file = _override->getOutputFile(_file, ctx, { image, 0u });
+	core::smart_refctd_ptr<ICPUImage> imageSmart;
+	if (asset::isIntegerFormat(viewParams.format))
+		imageSmart = IImageAssetHandlerBase::createImageDataForCommonWriting<EF_R32G32B32A32_UINT>(imageView,_params.logger);
+	else
+	{
+		bool halfFloat = true;
+		for (auto ch=0; ch<4; ch++)
+		if (getFormatMaxValue<hlsl::float64_t>(viewParams.format,ch)>getFormatMaxValue<hlsl::float64_t>(EF_R16G16B16A16_SFLOAT,ch))
+		{
+			halfFloat = false;
+			break;
+		}
+		if (halfFloat)
+			imageSmart = IImageAssetHandlerBase::createImageDataForCommonWriting<EF_R16G16B16A16_SFLOAT>(imageView,_params.logger);
+		else
+			imageSmart = IImageAssetHandlerBase::createImageDataForCommonWriting<EF_R32G32B32A32_SFLOAT>(imageView,_params.logger);
+	}
+
+	system::IFile* file = _override->getOutputFile(_file,ctx,{imageView,0u});
 	if (!file)
 		return false;
 
-	return writeImageBinary(file, image);
+	return writeImageBinary(file,imageSmart.get());
 }
 
 bool CImageWriterOpenEXR::writeImageBinary(system::IFile* file, const asset::ICPUImage* image)