Make SBinding::stageFlags a core::bitflag.

Author: achalpandeyy

include/nbl/asset/IDescriptorSetLayout.h

@@ -141,7 +141,7 @@ class NBL_API IDescriptorSetLayout : public virtual core::IReferenceCounted
 			uint32_t binding;
 			E_DESCRIPTOR_TYPE type;
 			core::bitflag<E_CREATE_FLAGS> createFlags;
-			IShader::E_SHADER_STAGE stageFlags; // TODO(achal): Should make a core::bitflag out of this as well?
+			core::bitflag<IShader::E_SHADER_STAGE> stageFlags;
 			uint32_t count;
 			// Use this if you want an immutable sampler that is baked into the DS layout itself.
 			// If its `nullptr` then the sampler used is mutable and can be specified while writing the image descriptor to a binding while updating the DS.
@@ -156,7 +156,7 @@ class NBL_API IDescriptorSetLayout : public virtual core::IReferenceCounted
 					{
 						if (count==rhs.count)
 						{
-							if (stageFlags==rhs.stageFlags)
+							if (stageFlags.value==rhs.stageFlags.value)
 							{
 								if (createFlags.value == rhs.createFlags.value)
 								{
@@ -170,7 +170,7 @@ class NBL_API IDescriptorSetLayout : public virtual core::IReferenceCounted
 								}
 								return createFlags.value < rhs.createFlags.value;
 							}
-							return stageFlags<rhs.stageFlags;
+							return stageFlags.value<rhs.stageFlags.value;
 						}
 						return count<rhs.count;
 					}
@@ -186,7 +186,7 @@ class NBL_API IDescriptorSetLayout : public virtual core::IReferenceCounted
 					return false;
 				if (count != rhs.count)
 					return false;
-				if (stageFlags != rhs.stageFlags)
+				if (stageFlags.value != rhs.stageFlags.value)
 					return false;
 				if (createFlags.value != rhs.createFlags.value)
 					return false;

include/nbl/video/IGPUCommandPool.h

@@ -255,32 +255,6 @@ class NBL_API IGPUCommandPool : public core::IReferenceCounted, public IBackendO
             CCommandSegment* tail = nullptr;
         };
 
-        struct Iterator
-        {
-            ICommand* cmd = nullptr;
-            CCommandSegment* segment = nullptr;
-
-            inline bool operator!=(const Iterator& other) const { return cmd != other.cmd; }
-
-            inline Iterator operator++(int)
-            {
-                Iterator old = *this;
-                if (cmd)
-                {
-                    assert(segment);
-
-                    // If `cmd` was "one past the end" then the size was wiped to 0 and it won't move.
-                    cmd = reinterpret_cast<ICommand*>(reinterpret_cast<uint8_t*>(cmd) + cmd->getSize());
-
-                    if (cmd == segment->segment_end())
-                        *this = segment->end();
-                }
-                return old;
-            }
-
-            inline ICommand* operator*() { return cmd; }
-        };
-
         CCommandSegmentListPool() : m_pool(COMMAND_SEGMENTS_PER_BLOCK*COMMAND_SEGMENT_SIZE, 0u, MAX_COMMAND_SEGMENT_BLOCK_COUNT, MIN_POOL_ALLOC_SIZE) {}
 
         template <typename Cmd, typename... Args>