and this is why, kids, you should always use explicit when declaring a constructor from an object of an unrelated type

Author: devshgraphicsprogramming

include/nbl/asset/utils/CDirQuantCacheBase.h

@@ -46,15 +46,20 @@ class CDirQuantCacheBase
 
 				Vector8u3() : x(0u),y(0u),z(0u) {}
 				Vector8u3(const Vector8u3&) = default;
-				Vector8u3(const core::vectorSIMDu32& val)
+				explicit Vector8u3(const core::vectorSIMDu32& val)
+				{
+					operator=(val);
+				}
+
+				Vector8u3& operator=(const Vector8u3&) = default;
+				Vector8u3& operator=(const core::vectorSIMDu32& val)
 				{
 					x = val.x;
 					y = val.y;
 					z = val.z;
+					return *this;
 				}
 
-				Vector8u3& operator=(const Vector8u3&) = default;
-
 				inline core::vectorSIMDu32 getValue() const
 				{
 					return core::vectorSIMDu32(x,y,z);
@@ -72,16 +77,21 @@ class CDirQuantCacheBase
 
 				Vector8u4() : x(0u),y(0u),z(0u),w(0u) {}
 				Vector8u4(const Vector8u4&) = default;
-				Vector8u4(const core::vectorSIMDu32& val)
+				explicit Vector8u4(const core::vectorSIMDu32& val)
+				{
+					operator=(val);
+				}
+
+				Vector8u4& operator=(const Vector8u4&) = default;
+				Vector8u4& operator=(const core::vectorSIMDu32& val)
 				{
 					x = val.x;
 					y = val.y;
 					z = val.z;
 					w = val.w;
+					return *this;
 				}
 
-				Vector8u4& operator=(const Vector8u4&) = default;
-
 				inline core::vectorSIMDu32 getValue() const
 				{
 					return core::vectorSIMDu32(x,y,z,w);
@@ -101,13 +111,19 @@ class CDirQuantCacheBase
 
 				Vector1010102() : storage(0u) {}
 				Vector1010102(const Vector1010102&) = default;
-				Vector1010102(const core::vectorSIMDu32& val)
+				explicit Vector1010102(const core::vectorSIMDu32& val)
+				{
+					operator=(val);
+				}
+
+				Vector1010102& operator=(const Vector1010102&) = default;
+				Vector1010102& operator=(const core::vectorSIMDu32& val)
 				{
 					constexpr auto storageBits = quantizationBits+1u;
 					storage = val.x|(val.y<<storageBits)|(val.z<<(storageBits*2u));
+					return *this;
 				}
 
-				Vector1010102& operator=(const Vector1010102&) = default;
 				inline bool operator<(const Vector1010102& other) const
 				{
 					return storage<other.storage;
@@ -136,15 +152,20 @@ class CDirQuantCacheBase
 
 				Vector16u3() : x(0u),y(0u),z(0u) {}
 				Vector16u3(const Vector16u3&) = default;
-				Vector16u3(const core::vectorSIMDu32& val)
+				explicit Vector16u3(const core::vectorSIMDu32& val)
+				{
+					operator=(val);
+				}
+
+				Vector16u3& operator=(const Vector16u3&) = default;
+				Vector16u3& operator=(const core::vectorSIMDu32& val)
 				{
 					x = val.x;
 					y = val.y;
 					z = val.z;
+					return *this;
 				}
 
-				Vector16u3& operator=(const Vector16u3&) = default;
-
 				inline core::vectorSIMDu32 getValue() const
 				{
 					return core::vectorSIMDu32(x,y,z);
@@ -162,16 +183,21 @@ class CDirQuantCacheBase
 
 				Vector16u4() : x(0u),y(0u),z(0u),w(0u) {}
 				Vector16u4(const Vector16u4&) = default;
-				Vector16u4(const core::vectorSIMDu32& val)
+				explicit Vector16u4(const core::vectorSIMDu32& val)
+				{
+					operator=(val);
+				}
+
+				Vector16u4& operator=(const Vector16u4&) = default;
+				Vector16u4& operator=(const core::vectorSIMDu32& val)
 				{
 					x = val.x;
 					y = val.y;
 					z = val.z;
 					w = val.w;
+					return *this;
 				}
 
-				Vector16u4& operator=(const Vector16u4&) = default;
-
 				inline core::vectorSIMDu32 getValue() const
 				{
 					return core::vectorSIMDu32(x,y,z,w);

src/nbl/asset/utils/CGeometryCreator.cpp

@@ -465,7 +465,8 @@ CGeometryCreator::return_type CGeometryCreator::createCylinderMesh(float radius,
     auto vtxBuf = core::make_smart_refctd_ptr<asset::ICPUBuffer>(vtxCnt*sizeof(CylinderVertex));
 
     CylinderVertex* vertices = reinterpret_cast<CylinderVertex*>(vtxBuf->getPointer());
-    std::fill(vertices, vertices + vtxCnt, CylinderVertex());
+	for (auto i=0ull; i<vtxCnt; i++)
+		vertices[i] = CylinderVertex();
 
     const uint32_t halfIx = tesselation;
 
@@ -528,7 +529,7 @@ CGeometryCreator::return_type CGeometryCreator::createConeMesh(	float radius, fl
 	ConeVertex* baseVertices = vertices;
 	ConeVertex* apexVertices = vertices + tesselation;
 
-    std::fill(vertices,vertices+vtxCnt, ConeVertex(core::vectorSIMDf(0.f),core::vectorSIMDu32(0u),colorBottom));
+    std::fill(vertices,vertices+vtxCnt, ConeVertex(core::vectorSIMDf(0.f),{},colorBottom));
 	CQuantNormalCache* const quantNormalCache = (meshManipulatorOverride == nullptr) ? defaultMeshManipulator->getQuantNormalCache() : meshManipulatorOverride->getQuantNormalCache();
 
     const float step = (2.f*core::PI<float>()) / tesselation;

src/nbl/asset/utils/CGeometryCreator.h

@@ -72,7 +72,7 @@ class CGeometryCreator : public IGeometryCreator
 
 		struct CylinderVertex
 		{
-			CylinderVertex() : pos{0.f, 0.f, 0.f}, color{0u, 0u, 0u, 0u}, uv{0.f, 0.f}, normal{0u} {}
+			CylinderVertex() : pos{0.f, 0.f, 0.f}, color{0u, 0u, 0u, 0u}, uv{0.f, 0.f}, normal() {}
 
 			float pos[3];
 			uint8_t color[4];