fix reduction bug

keptsecret · keptsecret · commit f2d6d8ac8cc0 · 2025-03-31T16:40:16.000+07:00
diff --git a/examples_tests b/examples_tests
@@ -1 +1 @@
-Subproject commit 3a2ff1421f81089749694db3032ce52068731551
+Subproject commit dd021a05605fa48ac5962db22d0a591c0ff7691d
diff --git a/include/nbl/builtin/hlsl/subgroup2/arithmetic_portability_impl.hlsl b/include/nbl/builtin/hlsl/subgroup2/arithmetic_portability_impl.hlsl
@@ -88,7 +88,7 @@ struct reduction
         scalar_t retval = value[0];
         //[unroll(ItemsPerInvocation-1)]
         for (uint32_t i = 1; i < ItemsPerInvocation; i++)
-            retval += binop(retval, value[i]);
+            retval = binop(retval, value[i]);
         return op(retval);
     }
 };

Original file line number	Diff line number	Diff line change
`@@ -88,7 +88,7 @@ struct reduction`
`88`	`88`	`scalar_t retval = value[0];`
`89`	`89`	`//[unroll(ItemsPerInvocation-1)]`
`90`	`90`	`for (uint32_t i = 1; i < ItemsPerInvocation; i++)`
`91`		`- retval += binop(retval, value[i]);`
	`91`	`+ retval = binop(retval, value[i]);`
`92`	`92`	`return op(retval);`
`93`	`93`	`}`
`94`	`94`	`};`