Merge pull request #709 from nipunG314/master

Add NBL_FP64_LITERAL macro

Author: devshgraphicsprogramming

include/nbl/builtin/hlsl/limits.hlsl

@@ -6,6 +6,7 @@
 
 #include <nbl/builtin/hlsl/type_traits.hlsl>
 #include <nbl/builtin/hlsl/bit.hlsl>
+#include <nbl/builtin/hlsl/macros.h>
 
 // C++ headers
 #ifndef __HLSL_VERSION
@@ -127,7 +128,7 @@ struct num_base : type_identity<T>
     NBL_CONSTEXPR_STATIC_INLINE int32_t float_max_decimal_exponent = 4*S16 + 30*S32 + 232*S64;
 
     NBL_CONSTEXPR_STATIC_INLINE int32_t float_exponent_bits = 8 * size - float_digits - 1;
-    NBL_CONSTEXPR_STATIC_INLINE int32_t float_max_exponent = 1l << float_exponent_bits;
+    NBL_CONSTEXPR_STATIC_INLINE int32_t float_max_exponent = 1 << float_exponent_bits;
     NBL_CONSTEXPR_STATIC_INLINE int32_t float_min_exponent = 3 - float_max_exponent;
     NBL_CONSTEXPR_STATIC_INLINE bool is_bool = is_same<T, bool>::value;
 
@@ -235,9 +236,9 @@ struct num_traits<float32_t> : num_base<float32_t>
 template<> 
 struct num_traits<float64_t> : num_base<float64_t>
 {
-    NBL_CONSTEXPR_STATIC_INLINE float64_t max           = 1.7976931348623158e+308;
-    NBL_CONSTEXPR_STATIC_INLINE float64_t min           = 2.2250738585072014e-308;
-    NBL_CONSTEXPR_STATIC_INLINE float64_t denorm_min    = 4.9406564584124654e-324;
+    NBL_CONSTEXPR_STATIC_INLINE float64_t max           = NBL_FP64_LITERAL(1.7976931348623158e+308);
+    NBL_CONSTEXPR_STATIC_INLINE float64_t min           = NBL_FP64_LITERAL(2.2250738585072014e-308);
+    NBL_CONSTEXPR_STATIC_INLINE float64_t denorm_min    = NBL_FP64_LITERAL(4.9406564584124654e-324);
     NBL_CONSTEXPR_STATIC_INLINE uint64_t  quiet_NaN     = 0x7FF8000000000000ull;
     NBL_CONSTEXPR_STATIC_INLINE uint64_t  signaling_NaN = 0x7FF0000000000001ull;
     NBL_CONSTEXPR_STATIC_INLINE uint64_t  infinity      = 0x7FF0000000000000ull;

include/nbl/builtin/hlsl/macros.h

@@ -17,6 +17,12 @@
 } 
 #endif
 
+#ifdef __HLSL_VERSION // cause DXC is insane
+#define NBL_FP64_LITERAL(LIT) LIT##l
+#else // and nobody except GCC supports C++23 `f64` suffix on float literals
+#define NBL_FP64_LITERAL(LIT) LIT
+#endif
+
 // basics
 #define NBL_EVAL(...) __VA_ARGS__
 #define NBL_CONCAT_IMPL2(X,Y) X ## Y
@@ -159,4 +165,4 @@
 
 #define NBL_FOREACH(WHAT, ... ) NBL_EVAL(NBL_CONCATENATE(NBL_FOREACH_,NBL_VA_ARGS_COUNT(__VA_ARGS__))(WHAT, __VA_ARGS__))
 
-#endif
+#endif