Skip to content

Commit f821530

Browse files
committed
Some few comments
1 parent 4f18bc8 commit f821530

File tree

2 files changed

+13
-6
lines changed

2 files changed

+13
-6
lines changed

include/nbl/video/SPhysicalDeviceFeatures.h

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -151,7 +151,7 @@ struct SPhysicalDeviceFeatures
151151

152152
bool scalarBlockLayout = false; // or VK_EXT_scalar_block_layout
153153

154-
//bool imagelessFramebuffer; // or VK_KHR_imageless_framebuffer // [FUTURE TODO]
154+
//bool imagelessFramebuffer; // or VK_KHR_imageless_framebuffer // [FUTURE TODO] https://github.com/Devsh-Graphics-Programming/Nabla/issues/378
155155

156156
bool uniformBufferStandardLayout = false; // or VK_KHR_uniform_buffer_standard_layout
157157

@@ -353,8 +353,6 @@ struct SPhysicalDeviceFeatures
353353
bool accelerationStructureHostCommands = false;
354354
bool descriptorBindingAccelerationStructureUpdateAfterBind = false;
355355

356-
/* [!!NV Version below, struct doesn't exist in vk headers] VK_KHR_fragment_shader_barycentric */
357-
358356
// [DO NOT EXPOSE] not implementing or exposing VRS in near or far future
359357
/* FragmentShadingRateFeaturesKHR *//* VK_KHR_fragment_shading_rate */
360358
//bool pipelineFragmentShadingRate;
@@ -375,7 +373,6 @@ struct SPhysicalDeviceFeatures
375373
bool rayQuery = false;
376374

377375
/* VK_KHR_ray_tracing !! Replaced/Removed */
378-
/* VK_KHR_ray_tracing_maintenance1 *//* added in vk 1.3.213, the SDK isn't released yet at this moment :D */
379376

380377
/* RayTracingPipelineFeaturesKHR *//* VK_KHR_ray_tracing_pipeline */
381378
bool rayTracingPipeline = false;
@@ -601,6 +598,9 @@ struct SPhysicalDeviceFeatures
601598
/* ShaderSMBuiltinsFeaturesNV *//* VK_NV_shader_sm_builtins */
602599
//bool shaderSMBuiltins;
603600

601+
// [TODO] Always enable, expose as limit
602+
/* VK_KHR_fragment_shader_barycentric */
603+
604604
// [TODO] Always enable, expose as limit
605605
/* VK_NV_geometry_shader_passthrough */
606606

@@ -615,10 +615,14 @@ struct SPhysicalDeviceFeatures
615615
/* GraphicsPipelineLibraryFeaturesEXT *//* VK_EXT_graphics_pipeline_library */
616616
//bool graphicsPipelineLibrary;
617617

618+
// [TODO]
619+
// lots of support for anything that isn't mobile (list of unsupported devices since the extension was published: https://pastebin.com/skZAbL4F)
620+
/* VK_KHR_format_feature_flags2 */ // Promoted to core 1.3;
621+
618622
// [TODO] this one isn't in the headers
619623
/* HostQueryResetFeatures *//* VK_EXT_host_query_reset *//* MOVED TO Vulkan 1.2 Core */
620624

621-
// [TODO] this one isn't in the headers
625+
// [TODO] this one isn't in the headers // Always enable, expose as limit
622626
/* VK_AMD_shader_early_and_late_fragment_tests */
623627
//bool shaderEarlyAndLateFragmentTests;
624628

@@ -641,6 +645,9 @@ struct SPhysicalDeviceFeatures
641645
// [TODO LATER] Won't expose for now, API changes necessary
642646
/* VK_AMD_texture_gather_bias_lod */
643647

648+
// [TODO LATER] when released in the SDK: https://github.com/Devsh-Graphics-Programming/Nabla/pull/357#discussion_r916899420
649+
/* VK_KHR_ray_tracing_maintenance1 *//* added in vk 1.3.213, the SDK isn't released yet at this moment :D */
650+
644651
// [TODO LATER] requires extra API work to use
645652
// GL Hint: in GL/GLES this is NV_scissor_exclusive
646653
/* ExclusiveScissorFeaturesNV *//* VK_NV_scissor_exclusive */
@@ -951,7 +958,6 @@ struct SPhysicalDeviceFeatures
951958
/* VK_EXT_separate_stencil_usage */
952959
/* VK_KHR_create_renderpass2 */
953960
/* VK_KHR_bind_memory2 */
954-
/* VK_KHR_format_feature_flags2 */
955961
/* VK_NV_viewport_array2 */
956962
/* VK_EXT_image_compression_control */
957963
/* VK_EXT_image_compression_control_swapchain */

src/nbl/video/IOpenGL_PhysicalDeviceBase.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -766,6 +766,7 @@ class IOpenGL_PhysicalDeviceBase : public IOpenGLPhysicalDeviceBase
766766
m_properties.limits.imageFootprint = m_glfeatures.isFeatureAvailable(COpenGLFeatureMap::NBL_NV_shader_texture_footprint);
767767

768768
// [TODO]
769+
// https://github.com/Devsh-Graphics-Programming/Nabla/pull/357#discussion_r917052568
769770
m_features.storagePushConstant8 = false;
770771
m_features.storagePushConstant16 = false;
771772
m_features.storageInputOutput16 = false;

0 commit comments

Comments
 (0)