Enabled VSI for FileSpec connector (PDAL#4720)

* enabled VSI for FileSpec connector

* changed error message check from VSI

Author: normanb

io/private/connector/Connector.cpp

@@ -140,6 +140,10 @@ std::vector<char> Connector::getBinary(const std::string& path) const
 
 arbiter::LocalHandle Connector::getLocalHandle(const std::string& path) const
 {
+    if (Utils::startsWith(Utils::toupper(path), "/VSI"))
+        // workaround so that arbiter path is not used to read/write with VSI
+        return arbiter::LocalHandle(path, false);
+
     if (m_arbiter->isLocal(path))
         return m_arbiter->getLocalHandle(path);
     else

test/unit/io/LasReaderTest.cpp

@@ -40,6 +40,7 @@
 #include <pdal/StageFactory.hpp>
 #include <pdal/Streamable.hpp>
 #include <pdal/util/FileUtils.hpp>
+#include <pdal/util/Utils.hpp>
 #include <io/HeaderVal.hpp>
 #include <io/LasHeader.hpp>
 #include <io/LasReader.hpp>
@@ -811,3 +812,28 @@ TEST(LasReaderTest, Laz_with_severals_extra_byte_with_wrong_options_name)
     ASSERT_TRUE(view->hasDim( layout->findDim("confidence") ));
     ASSERT_TRUE(view->hasDim( layout->findDim("Bad_Name") ));
 }
+
+TEST(LasReaderTest, remote_vsi)
+{
+    Options ops1;
+    ops1.add("filename", "/vsicurl/http://localhost/simple.laz");
+
+    LasReader reader;
+    reader.setOptions(ops1);
+
+    PointTable table;
+
+    // check we get past looking up the arbiter driver
+    EXPECT_THROW({
+        try
+        {
+            reader.prepare(table);
+        }
+        catch(const pdal_error& e)
+        {
+            EXPECT_TRUE(Utils::startsWith(e.what(),
+                "Unable to open stream for"));
+            throw;
+        }
+    }, pdal_error);
+}