Make operands to Kernel added in v5 optional

alan-baker · alan-baker · commit 30a41a43be6c · 2023-01-04T10:11:53.000-05:00
* The operands added to the Kernel instruction should be optional in the grammar since the extended instruction set describes a unified versioning system * This is a bugfix on KhronosGroup#308
diff --git a/include/spirv/unified1/extinst.nonsemantic.clspvreflection.grammar.json b/include/spirv/unified1/extinst.nonsemantic.clspvreflection.grammar.json
@@ -7,9 +7,9 @@
       "operands" : [
         { "kind" : "IdRef", "name" : "Kernel" },
         { "kind" : "IdRef", "name" : "Name" },
-        { "kind" : "IdRef", "name" : "NumArguments"},
-        { "kind" : "IdRef", "name" : "Flags" },
-        { "kind" : "IdRef", "name" : "Attributes" }
+        { "kind" : "IdRef", "name" : "NumArguments", "quantifier" : "?" },
+        { "kind" : "IdRef", "name" : "Flags", "quantifier" : "?"  },
+        { "kind" : "IdRef", "name" : "Attributes", "quantifier" : "?"  }
       ]
     },
     {

Original file line number	Diff line number	Diff line change
`@@ -7,9 +7,9 @@`
`7`	`7`	`"operands" : [`
`8`	`8`	`{ "kind" : "IdRef", "name" : "Kernel" },`
`9`	`9`	`{ "kind" : "IdRef", "name" : "Name" },`
`10`		`- { "kind" : "IdRef", "name" : "NumArguments"},`
`11`		`- { "kind" : "IdRef", "name" : "Flags" },`
`12`		`- { "kind" : "IdRef", "name" : "Attributes" }`
	`10`	`+ { "kind" : "IdRef", "name" : "NumArguments", "quantifier" : "?" },`
	`11`	`+ { "kind" : "IdRef", "name" : "Flags", "quantifier" : "?" },`
	`12`	`+ { "kind" : "IdRef", "name" : "Attributes", "quantifier" : "?" }`
`13`	`13`	`]`
`14`	`14`	`},`
`15`	`15`	`{`