Skip to content

Commit 4f4683b

Browse files
committed
Merge pull request flann-lib#115 from d40cht/master
Fix to memory errors signalled by valgrind in flann::any.
2 parents f0c56f0 + b615f26 commit 4f4683b

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

src/cpp/flann/util/any.h

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@ struct base_any_policy
4444
virtual void clone(void* const* src, void** dest) = 0;
4545
virtual void move(void* const* src, void** dest) = 0;
4646
virtual void* get_value(void** src) = 0;
47+
virtual void* get_value(void* const * src) = 0;
4748
virtual ::size_t get_size() = 0;
4849
virtual const std::type_info& type() = 0;
4950
virtual void print(std::ostream& out, void* const* src) = 0;
@@ -68,6 +69,7 @@ struct small_any_policy : typed_base_any_policy<T>
6869
virtual void clone(void* const* src, void** dest) { *dest = *src; }
6970
virtual void move(void* const* src, void** dest) { *dest = *src; }
7071
virtual void* get_value(void** src) { return reinterpret_cast<void*>(src); }
72+
virtual void* get_value(void* const * src) { return const_cast<void *>( reinterpret_cast<const void*>(src) ); }
7173
virtual void print(std::ostream& out, void* const* src) { out << *reinterpret_cast<T const*>(src); }
7274
};
7375

@@ -92,6 +94,7 @@ struct big_any_policy : typed_base_any_policy<T>
9294
**reinterpret_cast<T**>(dest) = **reinterpret_cast<T* const*>(src);
9395
}
9496
virtual void* get_value(void** src) { return *src; }
97+
virtual void* get_value(void* const * src) { return const_cast<void*>(*src); }
9598
virtual void print(std::ostream& out, void* const* src) { out << *reinterpret_cast<T const*>(*src); }
9699
};
97100

@@ -242,8 +245,7 @@ class any
242245
const T& cast() const
243246
{
244247
if (policy->type() != typeid(T)) throw anyimpl::bad_any_cast();
245-
void* obj = const_cast<void*>(object);
246-
T* r = reinterpret_cast<T*>(policy->get_value(&obj));
248+
T* r = reinterpret_cast<T*>(policy->get_value(&object));
247249
return *r;
248250
}
249251

0 commit comments

Comments
 (0)