Skip to content

Commit 360ba05

Browse files
committed
Attempt to fix chromium builds
It would seem that `glslang_sources` has a private dependency on `glslang_build_info`, so `glslang_validator` cannot transitively `#include` the generated `glslang/build_info.h` header. Add `glslang_build_info` as a direct dependency to `glslang_validator`. Also remove the duplicate dependency on `glslang_build_info` in `glslang_sources_common` Note: This is a speculative fix as I can build Chromium fine without these changes. Not sure what's different between these configs.
1 parent 0203976 commit 360ba05

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

BUILD.gn

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -242,7 +242,6 @@ template("glslang_sources_common") {
242242

243243
if (invoker.enable_opt) {
244244
deps += [
245-
":glslang_build_info",
246245
"${spirv_tools_dir}:spvtools_opt",
247246
"${spirv_tools_dir}:spvtools_val",
248247
]
@@ -289,6 +288,7 @@ executable("glslang_validator") {
289288
deps = [
290289
":glslang_default_resource_limits_sources",
291290
":glslang_sources",
291+
":glslang_build_info",
292292
]
293293
public_configs = [ ":glslang_hlsl" ]
294294

0 commit comments

Comments
 (0)