Skip to content

Commit 9783380

Browse files
committed
build: Make action targets hermetic
Fuchsia GN build requires all "action" targets to be hermetic, and they should correctly and fully state their inputs and ouptuts in "sources" and "outputs" fields (see https://fuchsia.dev/fuchsia-src/development/build/hermetic_actions for details). This change adds "sources" field to "glslang_extension_headers" build target so that it states all its input files in its GN target build rule. TEST=fx set workstation.x64 --args=build_should_trace_actions=true fx build Bug: 90846 Change-Id: I63bd5d03cee86d93b0bb7cf2cee95c5ae0d98f93
1 parent c9706bd commit 9783380

File tree

1 file changed

+9
-0
lines changed

1 file changed

+9
-0
lines changed

BUILD.gn

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,15 @@ action("glslang_extension_headers") {
7474

7575
out_file = "${target_gen_dir}/include/glslang/glsl_intrinsic_header.h"
7676

77+
# Fuchsia GN build rules require all GN actions to be hermetic and they
78+
# should correctly and fully state their inputs and outpus (see
79+
# https://fuchsia.dev/fuchsia-src/development/build/hermetic_actions
80+
# for details). All input files of the script should be added to the
81+
# |sources| list.
82+
sources = [
83+
"glslang/ExtensionHeaders/GL_EXT_shader_realtime_clock.glsl",
84+
]
85+
7786
inputs = [
7887
script
7988
]

0 commit comments

Comments
 (0)