Skip to content

Commit b99a6a7

Browse files
authored
Merge pull request KhronosGroup#2352 from ben-clayton/vs2015
Finalize glslang 10.15.3847, start glslang 11, drop support for VS2013
2 parents 9eef54b + c487d0f commit b99a6a7

File tree

4 files changed

+27
-13
lines changed

4 files changed

+27
-13
lines changed

.appveyor.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
# build version format
55
version: "{build}"
66

7-
os: Visual Studio 2013
7+
os: Visual Studio 2015
88

99
platform:
1010
- x64
@@ -58,7 +58,7 @@ build:
5858

5959
build_script:
6060
- mkdir build && cd build
61-
- cmake -G "Visual Studio 12 2013 Win64" -DCMAKE_INSTALL_PREFIX=install ..
61+
- cmake -G "Visual Studio 14 2015 Win64" -DCMAKE_INSTALL_PREFIX=install ..
6262
- cmake --build . --config %CONFIGURATION% --target install
6363

6464
test_script:
@@ -105,4 +105,4 @@ deploy:
105105
force_update: true
106106
on:
107107
branch: master
108-
APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2013
108+
APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2015

CHANGES.md

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,17 @@
33
All notable changes to this project will be documented in this file.
44
This project adheres to [Semantic Versioning](https://semver.org/).
55

6-
## 10.15.3847-dev 2020-06-16
6+
## 11.0.0 2020-07-20
7+
8+
### Breaking changes
9+
10+
#### Visual Studio 2013 is no longer supported
11+
12+
[As scheduled](https://github.com/KhronosGroup/glslang/blob/9eef54b2513ca6b40b47b07d24f453848b65c0df/README.md#planned-deprecationsremovals),
13+
Microsoft Visual Studio 2013 is no longer officially supported. Please upgrade
14+
to at least Visual Studio 2015.
15+
16+
## 10.15.3847 2020-07-20
717

818
### Breaking changes
919

README.md

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,14 @@
11
# News
22

3-
1. The versioning scheme is being improved, and you might notice some differences. This is currently WIP, but will be coming soon. See, for example, PR #2277.
3+
1. Visual Studio 2013 is no longer supported
44

5-
2. If you get a new **compilation error due to a missing header**, it might be caused by this planned removal:
5+
[As scheduled](https://github.com/KhronosGroup/glslang/blob/9eef54b2513ca6b40b47b07d24f453848b65c0df/README.md#planned-deprecationsremovals),
6+
Microsoft Visual Studio 2013 is no longer officially supported. \
7+
Please upgrade to at least Visual Studio 2015.
8+
9+
2. The versioning scheme is being improved, and you might notice some differences. This is currently WIP, but will be coming soon. See, for example, PR #2277.
10+
11+
3. If you get a new **compilation error due to a missing header**, it might be caused by this planned removal:
612

713
**SPIRV Folder, 1-May, 2020.** Glslang, when installed through CMake,
814
will install a `SPIRV` folder into `${CMAKE_INSTALL_INCLUDEDIR}`.
@@ -16,11 +22,6 @@ If people are only using this location to get spirv.hpp, I recommend they get th
1622
[![Build Status](https://travis-ci.org/KhronosGroup/glslang.svg?branch=master)](https://travis-ci.org/KhronosGroup/glslang)
1723
[![Build status](https://ci.appveyor.com/api/projects/status/q6fi9cb0qnhkla68/branch/master?svg=true)](https://ci.appveyor.com/project/Khronoswebmaster/glslang/branch/master)
1824

19-
## Planned Deprecations/Removals
20-
21-
1. **Visual Studio 2013, 20-July, 2020.** Keeping code compiling for MS Visual Studio 2013 will no longer be
22-
a goal as of July 20, 2020, the fifth anniversary of the release of Visual Studio 2015.
23-
2425
# Glslang Components and Status
2526

2627
There are several components:

build_info.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -100,12 +100,15 @@ def deduce_software_version(directory):
100100
for line in f.readlines():
101101
match = pattern.match(line)
102102
if match:
103+
flavor = match.group(4)
104+
if flavor == None:
105+
flavor = ""
103106
return {
104107
"major": match.group(1),
105108
"minor": match.group(2),
106109
"patch": match.group(3),
107-
"flavor": match.group(4).lstrip("-"),
108-
"-flavor": match.group(4),
110+
"flavor": flavor.lstrip("-"),
111+
"-flavor": flavor,
109112
"date": match.group(5),
110113
}
111114
raise Exception('No version number found in {}'.format(changes_file))

0 commit comments

Comments
 (0)