Skip to content

Commit 18e39cd

Browse files
committed
emit_spv: fix unintended fallthrough
1 parent 50aa70e commit 18e39cd

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

src/shady/emit/spirv/emit_spv.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -204,12 +204,14 @@ void emit_terminator(Emitter* emitter, FnBuilder fn_builder, BBBuilder basic_blo
204204
case Jump_TAG: {
205205
add_branch_phis(emitter, fn_builder, basic_block_builder, terminator);
206206
spvb_branch(basic_block_builder, find_reserved_id(emitter, terminator->payload.jump.target));
207+
return;
207208
}
208209
case Branch_TAG: {
209210
SpvId condition = emit_value(emitter, basic_block_builder, terminator->payload.branch.branch_condition);
210211
add_branch_phis(emitter, fn_builder, basic_block_builder, terminator->payload.branch.true_jump);
211212
add_branch_phis(emitter, fn_builder, basic_block_builder, terminator->payload.branch.false_jump);
212213
spvb_branch_conditional(basic_block_builder, condition, find_reserved_id(emitter, terminator->payload.branch.true_jump->payload.jump.target), find_reserved_id(emitter, terminator->payload.branch.false_jump->payload.jump.target));
214+
return;
213215
}
214216
case Switch_TAG: {
215217
SpvId inspectee = emit_value(emitter, basic_block_builder, terminator->payload.br_switch.switch_value);
@@ -222,6 +224,7 @@ void emit_terminator(Emitter* emitter, FnBuilder fn_builder, BBBuilder basic_blo
222224
SpvId default_tgt = find_reserved_id(emitter, terminator->payload.br_switch.default_jump->payload.jump.target);
223225

224226
spvb_switch(basic_block_builder, inspectee, default_tgt, terminator->payload.br_switch.case_jumps.count, targets);
227+
return;
225228
}
226229
case TailCall_TAG:
227230
case Join_TAG: error("Lower me");

0 commit comments

Comments
 (0)