default Generic global variables to being actually Global

Author: Hugobros3

src/shady/CMakeLists.txt

@@ -77,6 +77,7 @@ set(SHADY_SOURCES
     passes/lower_int64.c
     passes/lower_vec_arr.c
     passes/lower_workgroups.c
+    passes/lower_generic_globals.c
     passes/mark_leaf_functions.c
     passes/opt_inline.c
     passes/opt_stack.c

src/shady/compile.c

@@ -114,6 +114,7 @@ CompilationResult run_compiler_passes(CompilerConfig* config, Module** pmod) {
     RUN_PASS(lower_stack)
 
     RUN_PASS(lower_lea)
+    RUN_PASS(lower_generic_globals)
     RUN_PASS(lower_generic_ptrs)
     RUN_PASS(lower_physical_ptrs)
     RUN_PASS(lower_subgroup_vars)

src/shady/passes/lower_generic_globals.c

@@ -0,0 +1,51 @@
+#include "passes.h"
+
+#include "log.h"
+#include "portability.h"
+
+#include "../ir_private.h"
+#include "../type.h"
+#include "../rewrite.h"
+#include "../transform/ir_gen_helpers.h"
+
+typedef struct {
+    Rewriter rewriter;
+} Context;
+
+static const Node* process(Context* ctx, const Node* node) {
+    IrArena* a = ctx->rewriter.dst_arena;
+    switch (node->tag) {
+        case GlobalVariable_TAG: {
+            if (node->payload.global_variable.address_space == AsGeneric) {
+                AddressSpace dst_as = AsGlobalPhysical;
+                const Type* t = rewrite_node(&ctx->rewriter, node->payload.global_variable.type);
+                Node* new_global = global_var(ctx->rewriter.dst_module, rewrite_nodes(&ctx->rewriter, node->payload.global_variable.annotations), t, node->payload.global_variable.name, dst_as);
+
+                const Type* dst_t = ptr_type(a, (PtrType) { .pointed_type = t, .address_space = AsGeneric });
+                Nodes decl_annotations = singleton(annotation(a, (Annotation) { .name = "Generated" }));
+                Node* constant_decl = constant(ctx->rewriter.dst_module, decl_annotations, dst_t,
+                                            format_string_interned(a, "%s_generic", get_decl_name(node)));
+                const Node* result = ref_decl_helper(a, constant_decl);
+                constant_decl->payload.constant.instruction = prim_op_helper(a, convert_op, singleton(dst_t), singleton(ref_decl_helper(a, new_global)));
+                register_processed(&ctx->rewriter, node, result);
+                new_global->payload.global_variable.init = rewrite_node(&ctx->rewriter, node->payload.global_variable.init);
+                return result;
+            }
+        }
+        default: break;
+    }
+
+    return recreate_node_identity(&ctx->rewriter, node);
+}
+
+Module* lower_generic_globals(SHADY_UNUSED const CompilerConfig* config, Module* src) {
+    ArenaConfig aconfig = get_arena_config(get_module_arena(src));
+    IrArena* a = new_ir_arena(aconfig);
+    Module* dst = new_module(a, get_module_name(src));
+    Context ctx = {
+        .rewriter = create_rewriter(src, dst, (RewriteNodeFn) process),
+    };
+    rewrite_module(&ctx.rewriter);
+    destroy_rewriter(&ctx.rewriter);
+    return dst;
+}

src/shady/passes/passes.h

@@ -71,6 +71,7 @@ RewritePass lower_memory_layout;
 RewritePass lower_memcpy;
 /// Eliminates pointers to unsized arrays from the IR. Needs lower_lea to have ran first!
 RewritePass lower_decay_ptrs;
+RewritePass lower_generic_globals;
 
 /// @}