dump module when verify_scopes fails

Author: Hugobros3

src/shady/analysis/verify.c

@@ -42,7 +42,7 @@ static void verify_same_arena(Module* mod) {
     destroy_dict(visitor.once);
 }
 
-static void verify_scoping(Module* mod) {
+static void verify_scoping(const CompilerConfig* config, Module* mod) {
     struct List* scopes = build_scopes(mod);
     for (size_t i = 0; i < entries_count_list(scopes); i++) {
         Scope* scope = read_list(Scope*, scopes)[i];
@@ -54,7 +54,10 @@ static void verify_scoping(Module* mod) {
             log_node(ERROR, leaking);
             error_print("\n");
         }
-        assert(entries_count_dict(entry_vars->free_set) == 0);
+        if (entries_count_dict(entry_vars->free_set) > 0) {
+            log_module(ERROR, config, mod);
+            error_die();
+        }
         destroy_scope_variables_map(map);
         destroy_scope(scope);
     }
@@ -118,12 +121,12 @@ static void verify_bodies(Module* mod) {
     }
 }
 
-void verify_module(Module* mod) {
+void verify_module(const CompilerConfig* config, Module* mod) {
     verify_same_arena(mod);
     // before we normalize the IR, scopes are broken because decls appear where they should not
     // TODO add a normalized flag to the IR and check grammar is adhered to strictly
     if (get_module_arena(mod)->config.check_types) {
-        verify_scoping(mod);
+        verify_scoping(config, mod);
         verify_bodies(mod);
     }
 }

src/shady/analysis/verify.h

@@ -3,6 +3,6 @@
 
 #include "shady/ir.h"
 
-void verify_module(Module*);
+void verify_module(const CompilerConfig*, Module*);
 
 #endif

src/shady/compile.h

@@ -17,7 +17,7 @@ old_mod = *pmod;                                        \
 *pmod = pass_name(config, *pmod);                       \
 (*pmod)->sealed = true;                                 \
 if (SHADY_RUN_VERIFY)                                   \
-  verify_module(*pmod);                                 \
+  verify_module(config, *pmod);                         \
 if (get_module_arena(old_mod) != get_module_arena(*pmod) && get_module_arena(old_mod) != initial_arena) \
   destroy_ir_arena(get_module_arena(old_mod));          \
 old_mod = *pmod;                                        \
@@ -26,7 +26,7 @@ if (config->optimisations.cleanup.after_every_pass)     \
 debugvv_print("After "#pass_name" pass: \n");           \
 log_module(DEBUGVV, config, *pmod);                     \
 if (SHADY_RUN_VERIFY)                                   \
-  verify_module(*pmod);                                 \
+  verify_module(config, *pmod);                         \
 if (get_module_arena(old_mod) != get_module_arena(*pmod) && get_module_arena(old_mod) != initial_arena) \
   destroy_ir_arena(get_module_arena(old_mod));          \
 if (config->hooks.after_pass.fn)                        \

src/shady/passes/opt_mem2reg.c

@@ -688,7 +688,7 @@ Module* opt_mem2reg(const CompilerConfig* config, Module* src) {
         destroy_dict(ctx.bb_new_args);
         destroy_arena(ctx.a);
 
-        verify_module(dst);
+        verify_module(config, dst);
 
         if (get_module_arena(src) != initial_arena)
             destroy_ir_arena(get_module_arena(src));

src/shady/print.c

@@ -973,7 +973,6 @@ void print_module(Printer* printer, Module* mod, PrintConfig config) {
     };
     print_mod_impl(&ctx, mod);
     flush(ctx.printer);
-    destroy_printer(ctx.printer);
 }
 
 void print_node(Printer* printer, const Node* node, PrintConfig config) {