Skip to content

Commit 159bf5f

Browse files
authored
Merge pull request kubernetes-sigs#3464 from DhairyaMajmudar/fix-disable-tracing
backend: telemetry: disable tracing by default
2 parents 231e048 + 65a5e1c commit 159bf5f

File tree

2 files changed

+14
-1
lines changed

2 files changed

+14
-1
lines changed

Makefile

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -117,6 +117,19 @@ else
117117
@cmd /c "set HEADLAMP_BACKEND_TOKEN=headlamp&& set HEADLAMP_CONFIG_METRICS_ENABLED=true&& set HEADLAMP_CONFIG_ENABLE_HELM=true&& set HEADLAMP_CONFIG_ENABLE_DYNAMIC_CLUSTERS=true&& backend\headlamp-server -dev -proxy-urls https://artifacthub.io/* -listen-addr=localhost"
118118
endif
119119

120+
run-backend-with-traces:
121+
@echo "**** Running backend with distributed tracing enabled ****"
122+
ifeq ($(UNIXSHELL),true)
123+
HEADLAMP_BACKEND_TOKEN=headlamp \
124+
HEADLAMP_CONFIG_TRACING_ENABLED=true \
125+
HEADLAMP_CONFIG_ENABLE_HELM=true \
126+
HEADLAMP_CONFIG_ENABLE_DYNAMIC_CLUSTERS=true \
127+
./backend/headlamp-server -dev -proxy-urls https://artifacthub.io/* -listen-addr=localhost
128+
else
129+
@echo "**** Running on Windows without bash or zsh. ****"
130+
@cmd /c "set HEADLAMP_BACKEND_TOKEN=headlamp&& set HEADLAMP_CONFIG_TRACING_ENABLED=true&& set HEADLAMP_CONFIG_ENABLE_HELM=true&& set HEADLAMP_CONFIG_ENABLE_DYNAMIC_CLUSTERS=true&& backend\headlamp-server -dev -proxy-urls https://artifacthub.io/* -listen-addr=localhost"
131+
endif
132+
120133
run-frontend:
121134
ifeq ($(UNIXSHELL),true)
122135
cd frontend && nice -16 npm start

backend/pkg/config/config.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -223,7 +223,7 @@ func flagset() *flag.FlagSet {
223223
// Telemetry flags.
224224
f.String("service-name", "headlamp", "Service name for telemetry")
225225
f.String("service-version", "0.30.0", "Service version for telemetry")
226-
f.Bool("tracing-enabled", true, "Enable distributed tracing")
226+
f.Bool("tracing-enabled", false, "Enable distributed tracing")
227227
f.Bool("metrics-enabled", false, "Enable metrics collection")
228228
f.String("otlp-endpoint", "localhost:4317", "OTLP collector endpoint")
229229
f.Bool("use-otlp-http", false, "Use HTTP instead of gRPC for OTLP export")

0 commit comments

Comments
 (0)