Merge pull request #430 from DialmasterOrg/fix/426-permission-error-channel-downloads

fix(#426): use configurable tmp path

Author: dialmaster

.github/workflows/claude.yml

@@ -41,7 +41,9 @@ jobs:
             - Security implications
             - Performance considerations
 
-            The PR branch is already checked out. Use `gh pr diff ${{ github.event.pull_request.number }}` to see the changes.
+            Use `gh pr diff ${{ github.event.pull_request.number }}` to see the changes.
+
+            IMPORTANT: Only use `gh` commands. Do NOT run tests, npm commands, or any other shell commands.
 
             Post your review as a comment on the PR using `gh pr comment ${{ github.event.pull_request.number }} --body "your review here"`.
             Only post GitHub comments - don't just output text.

server/modules/__tests__/videoValidationModule.test.js

@@ -1,5 +1,11 @@
 /* eslint-env jest */
 
+// Mock tempPathManager before any module that depends on it is loaded
+// This prevents configModule's file watcher from starting
+jest.mock('../download/tempPathManager', () => ({
+  getTempBasePath: jest.fn(() => '/tmp/youtarr-downloads'),
+}));
+
 const videoValidationModule = require('../videoValidationModule');
 const ytDlpRunner = require('../ytDlpRunner');
 const archiveModule = require('../archiveModule');

server/modules/__tests__/ytDlpRunner.test.js

@@ -84,6 +84,10 @@ describe('YtDlpRunner', () => {
     };
     jest.doMock('../download/ytdlpCommandBuilder', () => ytdlpCommandBuilderMock);
 
+    jest.doMock('../download/tempPathManager', () => ({
+      getTempBasePath: jest.fn(() => '/tmp/youtarr-downloads')
+    }));
+
     loadModule();
   });
 

server/modules/__tests__/ytdlpModule.test.js

@@ -15,6 +15,10 @@ jest.mock('../jobModule', () => ({
   getInProgressJobId: jest.fn(),
 }));
 
+jest.mock('../download/tempPathManager', () => ({
+  getTempBasePath: jest.fn(() => '/tmp/youtarr-downloads'),
+}));
+
 // Mock logger
 jest.mock('../../logger', () => ({
   info: jest.fn(),
@@ -393,7 +397,11 @@ describe('ytdlpModule', () => {
 
       const result = await updatePromise;
       expect(result.success).toBe(true);
-      expect(spawn).toHaveBeenCalledWith('yt-dlp', ['-U']);
+      expect(spawn).toHaveBeenCalledWith('yt-dlp', ['-U'], expect.objectContaining({
+        env: expect.objectContaining({
+          TMPDIR: '/tmp/youtarr-downloads'
+        })
+      }));
     });
 
     it('resets update state after completion', async () => {

server/modules/channelModule.js

@@ -12,6 +12,7 @@ const { Op, fn, col, where } = require('sequelize');
 const fileCheckModule = require('./fileCheckModule');
 const logger = require('../logger');
 const { sanitizeNameLikeYtDlp } = require('./filesystem');
+const tempPathManager = require('./download/tempPathManager');
 
 const { v4: uuidv4 } = require('uuid');
 const { spawn, execSync } = require('child_process');
@@ -151,7 +152,7 @@ class ChannelModule {
     const ytDlp = spawn('yt-dlp', args, {
       env: {
         ...process.env,
-        TMPDIR: '/tmp'
+        TMPDIR: tempPathManager.getTempBasePath()
       }
     });
 

server/modules/download/__tests__/ytdlpCommandBuilder.test.js

@@ -297,6 +297,20 @@ describe('YtdlpCommandBuilder', () => {
     });
   });
 
+  describe('buildTempPathArgs', () => {
+    it('should return --paths temp: args with temp base path', () => {
+      tempPathManager.getTempBasePath.mockReturnValue('/mock/youtube/output/.youtarr_tmp');
+      const result = YtdlpCommandBuilder.buildTempPathArgs();
+      expect(result).toEqual(['--paths', 'temp:/mock/youtube/output/.youtarr_tmp']);
+    });
+
+    it('should use external temp path when configured', () => {
+      tempPathManager.getTempBasePath.mockReturnValue('/tmp/youtarr-downloads');
+      const result = YtdlpCommandBuilder.buildTempPathArgs();
+      expect(result).toEqual(['--paths', 'temp:/tmp/youtarr-downloads']);
+    });
+  });
+
   describe('buildSubtitleArgs', () => {
     it('should return empty array when subtitles disabled', () => {
       const config = { subtitlesEnabled: false };
@@ -523,6 +537,11 @@ describe('YtdlpCommandBuilder', () => {
       expect(result).toContain('--fragment-retries');
       expect(result).toContain('2');
 
+      // Check temp path args (fixes permission errors on Docker setups)
+      expect(result).toContain('--paths');
+      const pathsIndex = result.indexOf('--paths');
+      expect(result[pathsIndex + 1]).toMatch(/^temp:/);
+
       // Check progress template
       expect(result).toContain('--newline');
       expect(result).toContain('--progress');

server/modules/download/downloadExecutor.js

@@ -412,7 +412,7 @@ class DownloadExecutor {
         env: {
           ...process.env,
           YOUTARR_JOB_ID: jobId,
-          TMPDIR: '/tmp',
+          TMPDIR: tempPathManager.getTempBasePath(),
           // Pass subfolder override to post-processor (empty string means no override)
           ...(subfolderOverride !== null && subfolderOverride !== undefined
             ? { YOUTARR_SUBFOLDER_OVERRIDE: subfolderOverride }

server/modules/download/ytdlpCommandBuilder.js

@@ -125,6 +125,17 @@ class YtdlpCommandBuilder {
     return [];
   }
 
+  /**
+   * Build temp path args for yt-dlp internal temp files
+   * This redirects yt-dlp's internal temp files (used during download/merge operations)
+   * to our already-writable staging directory, fixing permission errors on some Docker setups.
+   * @returns {string[]} - Array with --paths temp: argument
+   */
+  static buildTempPathArgs() {
+    const tempPath = tempPathManager.getTempBasePath();
+    return ['--paths', `temp:${tempPath}`];
+  }
+
   /**
    * Build audio extraction args for MP3 downloads
    * @param {string|null} audioFormat - 'video_mp3' or 'mp3_only', null for video only
@@ -150,7 +161,7 @@ class YtdlpCommandBuilder {
 
   /**
    * Build arguments that ALWAYS apply to any yt-dlp invocation
-   * Includes: IPv4 enforcement, proxy, sleep-requests, and cookies
+   * Includes: IPv4 enforcement, proxy, sleep-requests, cookies, and temp path
    * @param {Object} config - Configuration object
    * @param {Object} options - Options for building args
    * @param {boolean} options.skipSleepRequests - Skip adding --sleep-requests (for single metadata fetches)
@@ -184,6 +195,10 @@ class YtdlpCommandBuilder {
       args.push('--cookies', cookiesPath);
     }
 
+    // Add temp path for yt-dlp's internal temp files
+    // This fixes permission errors on Docker setups where /tmp may not be writable
+    args.push(...this.buildTempPathArgs());
+
     return args;
   }
 

server/modules/videoDownloadPostProcessFiles.js

@@ -61,7 +61,7 @@ async function downloadChannelThumbnailIfMissing(channelId) {
       const result = spawnSync('yt-dlp', ytdlpArgs, {
         env: {
           ...process.env,
-          TMPDIR: '/tmp'
+          TMPDIR: tempPathManager.getTempBasePath()
         },
         encoding: 'utf8'
       });

server/modules/ytDlpRunner.js

@@ -1,6 +1,7 @@
 const { spawn } = require('child_process');
 const path = require('path');
 const fs = require('fs');
+const tempPathManager = require('./download/tempPathManager');
 
 class YtDlpRunner {
   constructor() {
@@ -31,7 +32,7 @@ class YtDlpRunner {
         timeout: timeoutMs,
         env: {
           ...process.env,
-          TMPDIR: '/tmp'
+          TMPDIR: tempPathManager.getTempBasePath()
         }
       });