Redesign attribute callbacks (#237)

Author: GDYendell

docs/conf.py

@@ -88,6 +88,8 @@
     ("py:class", "p4p.nt.ndarray.NTNDArray"),
     ("py:class", "p4p.nt.NTTable"),
     # Problems in FastCS itself
+    ("py:class", "T"),
+    ("py:class", "AttrIOUpdateCallback"),
     ("py:class", "fastcs.transport.epics.pva.pvi_tree._PviSignalInfo"),
     ("py:class", "fastcs.logging._logging.LogLevel"),
     ("py:class", "fastcs.logging._graylog.GraylogEndpoint"),
@@ -102,6 +104,7 @@
 ]
 nitpick_ignore_regex = [
     ("py:class", "fastcs.*.T"),
+    ("py:obj", "fastcs.*.T"),
     (r"py:.*", r"fastcs\.demo.*"),
     (r"py:.*", r"tickit.*"),
 ]

docs/snippets/dynamic.py

@@ -79,7 +79,7 @@ async def update(self, attr: AttrR[NumberT, TemperatureControllerAttributeIORef]
         response = await self._connection.send_query(f"{query}\r\n")
         value = response.strip("\r\n")
 
-        await attr.set(attr.dtype(value))
+        await attr.update(attr.dtype(value))
 
     async def send(
         self, attr: AttrW[NumberT, TemperatureControllerAttributeIORef], value: NumberT

docs/snippets/static07.py

@@ -30,7 +30,7 @@ async def update(self, attr: AttrR[NumberT, IDAttributeIORef]):
         response = await self._connection.send_query("ID?\r\n")
         value = response.strip("\r\n")
 
-        await attr.set(attr.dtype(value))
+        await attr.update(attr.dtype(value))
 
 
 class TemperatureController(Controller):

docs/snippets/static08.py

@@ -35,7 +35,7 @@ async def update(self, attr: AttrR[NumberT, TemperatureControllerAttributeIORef]
         response = await self._connection.send_query(f"{query}\r\n")
         value = response.strip("\r\n")
 
-        await attr.set(attr.dtype(value))
+        await attr.update(attr.dtype(value))
 
 
 class TemperatureController(Controller):

docs/snippets/static09.py

@@ -35,7 +35,7 @@ async def update(self, attr: AttrR[NumberT, TemperatureControllerAttributeIORef]
         response = await self._connection.send_query(f"{query}\r\n")
         value = response.strip("\r\n")
 
-        await attr.set(attr.dtype(value))
+        await attr.update(attr.dtype(value))
 
     async def send(
         self, attr: AttrW[NumberT, TemperatureControllerAttributeIORef], value: NumberT

docs/snippets/static10.py

@@ -36,7 +36,7 @@ async def update(self, attr: AttrR[NumberT, TemperatureControllerAttributeIORef]
         response = await self._connection.send_query(f"{query}\r\n")
         value = response.strip("\r\n")
 
-        await attr.set(attr.dtype(value))
+        await attr.update(attr.dtype(value))
 
     async def send(
         self, attr: AttrW[NumberT, TemperatureControllerAttributeIORef], value: NumberT

docs/snippets/static11.py

@@ -37,7 +37,7 @@ async def update(self, attr: AttrR[NumberT, TemperatureControllerAttributeIORef]
         response = await self._connection.send_query(f"{query}\r\n")
         value = response.strip("\r\n")
 
-        await attr.set(attr.dtype(value))
+        await attr.update(attr.dtype(value))
 
     async def send(
         self, attr: AttrW[NumberT, TemperatureControllerAttributeIORef], value: NumberT

docs/snippets/static12.py

@@ -39,7 +39,7 @@ async def update(self, attr: AttrR[NumberT, TemperatureControllerAttributeIORef]
         response = await self._connection.send_query(f"{query}\r\n")
         value = response.strip("\r\n")
 
-        await attr.set(attr.dtype(value))
+        await attr.update(attr.dtype(value))
 
     async def send(
         self, attr: AttrW[NumberT, TemperatureControllerAttributeIORef], value: NumberT
@@ -94,7 +94,7 @@ async def update_voltages(self):
             (await self._connection.send_query("V?\r\n")).strip("\r\n")
         )
         for index, controller in enumerate(self._ramp_controllers):
-            await controller.voltage.set(float(voltages[index]))
+            await controller.voltage.update(float(voltages[index]))
 
 
 gui_options = EpicsGUIOptions(

docs/snippets/static13.py

@@ -40,7 +40,7 @@ async def update(self, attr: AttrR[NumberT, TemperatureControllerAttributeIORef]
         response = await self._connection.send_query(f"{query}\r\n")
         value = response.strip("\r\n")
 
-        await attr.set(attr.dtype(value))
+        await attr.update(attr.dtype(value))
 
     async def send(
         self, attr: AttrW[NumberT, TemperatureControllerAttributeIORef], value: NumberT
@@ -95,12 +95,12 @@ async def update_voltages(self):
             (await self._connection.send_query("V?\r\n")).strip("\r\n")
         )
         for index, controller in enumerate(self._ramp_controllers):
-            await controller.voltage.set(float(voltages[index]))
+            await controller.voltage.update(float(voltages[index]))
 
     @command()
     async def disable_all(self) -> None:
         for rc in self._ramp_controllers:
-            await rc.enabled.process(OnOffEnum.Off)
+            await rc.enabled.put(OnOffEnum.Off, sync_setpoint=True)
             # TODO: The requests all get concatenated and the sim doesn't handle it
             await asyncio.sleep(0.1)
 

src/fastcs/attribute_io.py

@@ -1,7 +1,7 @@
 from typing import Any, Generic, cast, get_args
 
 from fastcs.attribute_io_ref import AttributeIORef, AttributeIORefT
-from fastcs.attributes import AttrR, AttrRW
+from fastcs.attributes import AttrR, AttrW
 from fastcs.datatypes import T
 from fastcs.tracer import Tracer
 
@@ -32,7 +32,7 @@ def __init__(self):
     async def update(self, attr: AttrR[T, AttributeIORefT]) -> None:
         raise NotImplementedError()
 
-    async def send(self, attr: AttrRW[T, AttributeIORefT], value: T) -> None:
+    async def send(self, attr: AttrW[T, AttributeIORefT], value: T) -> None:
         raise NotImplementedError()