fixes from Garys PR comments

Author: gilesknap

Charts/README_CHARTS.md Charts/README.mdCharts/README_CHARTS.md renamed to Charts/README.md

@@ -17,8 +17,8 @@ useHelmDocs: false
 noAdditionalProperties: false
 
 schemaRoot:
-  title: FastCS Helm chart schema
-  description: Schema to allow validation of values passed to FastCS Helm chart
+  title: FastCS Helm chart
+  description: Helm chart for deploying a FastCS application
   # No additional properties in schema root for tighter protection:
   additionalProperties: false
 

Charts/fastcs/.schema.config.yaml

@@ -1,6 +1,6 @@
 apiVersion: v2
 name: fastcs
-description: A Helm chart for Kubernetes
+description: A Helm chart for FastCS Applications
 
 # A chart can be either an 'application' or a 'library' chart.
 #

Charts/fastcs/Chart.yaml

@@ -1,7 +1,7 @@
 {
     "$schema": "https://json-schema.org/draft/2020-12/schema",
-    "title": "FastCS Helm chart schema",
-    "description": "Schema to allow validation of values passed to FastCS Helm chart",
+    "title": "FastCS Helm chart",
+    "description": "Helm chart for deploying a FastCS application",
     "type": "object",
     "properties": {
         "affinity": {

Charts/fastcs/values.schema.json

@@ -35,7 +35,7 @@ initCommand:
   - /bin/bash
   - -c
   - |
-    echo "running as account"; id
+    echo "Running as account"; id
     if [ -d /dest/venv ]; then
       echo "Virtual environment already exists, skipping copy"
     else

Charts/fastcs/values.yaml

@@ -8,11 +8,11 @@ RUN apt-get update && apt-get install -y --no-install-recommends \
     graphviz \
     && rm -rf /var/lib/apt/lists/*
 
-    # Install helm for the dev container. This is the recommended
+# Install helm for the dev container. This is the recommended
 # approach per the docs: https://helm.sh/docs/intro/install
-RUN curl -fsSL -o get_helm.sh https://raw.githubusercontent.com/helm/helm/main/scripts/get-helm-3; \
-    chmod 700 get_helm.sh; \
-    ./get_helm.sh; \
+RUN curl -fsSL -o get_helm.sh https://raw.githubusercontent.com/helm/helm/main/scripts/get-helm-3 && \
+    chmod 700 get_helm.sh && \
+    ./get_helm.sh && \
     rm get_helm.sh
 RUN helm plugin install https://github.com/losisin/helm-values-schema-json.git