fix values.yaml schema for extraContainers

Using losisin/helm-values-schema-json#251 (comment)

Author: gilesknap

Charts/fastcs/.schema.config.yaml

@@ -3,6 +3,7 @@
 # Define input, output and source for $refs relative to repository root for pre-commit
 values:
   - Charts/fastcs/values.yaml
+  - Charts/fastcs/extra.values.yaml
 
 output: Charts/fastcs/values.schema.json
 

Charts/fastcs/extra.values.yaml

@@ -0,0 +1,15 @@
+################################################################################
+# values for lists of custom objects from values.yaml for schema generation
+################################################################################
+
+# @schema description: Add arbitrary containers to the pod
+extraContainers:
+  # @schema: description: A name for the additional container
+  - name: container_name
+    # @schema  $ref: $k8s/container.json#/properties/image
+    image: image_uri
+    # @schema  $ref: $k8s/container.json#/properties/command
+    command:
+      - command
+      - arg1
+      - arg2

Charts/fastcs/values.schema.json

@@ -46,9 +46,26 @@
             "type": "boolean"
         },
         "extraContainers": {
+            "description": "Add arbitrary containers to the pod",
             "type": "array",
             "items": {
-                "type": "object"
+                "type": "object",
+                "properties": {
+                    "command": {
+                        "$ref": "https://raw.githubusercontent.com/yannh/kubernetes-json-schema/master/v1.33.3/container.json#/properties/command",
+                        "type": "array",
+                        "items": {
+                            "type": "string"
+                        }
+                    },
+                    "image": {
+                        "$ref": "https://raw.githubusercontent.com/yannh/kubernetes-json-schema/master/v1.33.3/container.json#/properties/image",
+                        "type": "string"
+                    },
+                    "name": {
+                        "type": "string"
+                    }
+                }
             }
         },
         "global": {

Charts/fastcs/values.yaml

@@ -85,14 +85,8 @@ service:
   ca_port: 5064
   pva_port: 5075
 
-
-# Add addtional containers specified by image and command
-#
-# should be of the form:
-#     name: # A name for the additional container
-#     image: # Container image URI
-#     command: # Command to run in the container (as array of arguments)
-# @schema item: object
+# Add additional containers specified by image and command
+# see extra.values.yaml for the schema of this list of objects
 extraContainers: []
 
 # @schema description: Add annotations to the pod