Skip to content

Commit aad1a85

Browse files
authored
Pass precision to widget for Int and Float (#299)
1 parent 3edcc06 commit aad1a85

File tree

2 files changed

+10
-6
lines changed

2 files changed

+10
-6
lines changed

src/fastcs/transports/epics/gui.py

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -61,8 +61,10 @@ def _get_read_widget(self, fastcs_datatype: DataType) -> ReadWidgetUnion | None:
6161
match fastcs_datatype:
6262
case Bool():
6363
return LED()
64-
case Int() | Float():
65-
return TextRead()
64+
case Int():
65+
return TextRead(precision=0)
66+
case Float(prec=precision):
67+
return TextRead(precision=precision)
6668
case String():
6769
return TextRead(format=TextFormat.string)
6870
case Enum():
@@ -80,8 +82,10 @@ def _get_write_widget(self, fastcs_datatype: DataType) -> WriteWidgetUnion | Non
8082
match fastcs_datatype:
8183
case Bool():
8284
return ToggleButton()
83-
case Int() | Float():
84-
return TextWrite()
85+
case Int():
86+
return TextWrite(precision=0)
87+
case Float(prec=precision):
88+
return TextWrite(precision=precision)
8589
case String():
8690
return TextWrite(format=TextFormat.string)
8791
case Enum():

tests/transports/epics/pva/test_pva_gui.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ def test_get_attribute_component_table_write():
6464
assert isinstance(attribute_component, SignalW)
6565
assert isinstance(attribute_component.write_widget, TableWrite)
6666
assert attribute_component.write_widget.widgets == [
67-
TextWrite(),
67+
TextWrite(precision=0),
6868
CheckBox(),
6969
TextWrite(format=TextFormat.string),
7070
]
@@ -90,7 +90,7 @@ def test_get_attribute_component_table_read():
9090
assert isinstance(attribute_component, SignalR)
9191
assert isinstance(attribute_component.read_widget, TableRead)
9292
assert attribute_component.read_widget.widgets == [
93-
TextRead(),
93+
TextRead(precision=0),
9494
LED(),
9595
TextRead(format=TextFormat.string),
9696
]

0 commit comments

Comments
 (0)