Remove tango polling

Author: marcelldls

src/fastcs/backends/tango/dsr.py

@@ -25,23 +25,12 @@ def _wrap_updater_fget(
     attr_name: str, attribute: AttrR, controller: BaseController
 ) -> Callable[[Any], Any]:
     async def fget(tango_device: Device):
-        assert attribute.updater is not None
-
-        await attribute.updater.update(controller, attribute)
         tango_device.info_stream(f"called fget method: {attr_name}")
         return attribute.get()
 
     return fget
 
 
-def _tango_polling_period(attribute: AttrR) -> int:
-    if attribute.updater is not None:
-        # Convert to integer milliseconds
-        return int(attribute.updater.update_period * 1000)
-
-    return -1  # `tango.server.attribute` default for `polling_period`
-
-
 def _tango_display_format(attribute: Attribute) -> str:
     match attribute.datatype:
         case Float(prec):
@@ -54,10 +43,8 @@ def _wrap_updater_fset(
     attr_name: str, attribute: AttrW, controller: BaseController
 ) -> Callable[[Any, Any], Any]:
     async def fset(tango_device: Device, val):
-        assert attribute.sender is not None
-
-        await attribute.sender.put(controller, attribute, val)
         tango_device.info_stream(f"called fset method: {attr_name}")
+        await attribute.process_without_display_update(val)
 
     return fset
 
@@ -84,7 +71,6 @@ def _collect_dev_attributes(mapping: Mapping) -> dict[str, Any]:
                         ),
                         access=AttrWriteType.READ_WRITE,
                         format=_tango_display_format(attribute),
-                        polling_period=_tango_polling_period(attribute),
                     )
                 case AttrR():
                     collection[d_attr_name] = server.attribute(
@@ -95,7 +81,6 @@ def _collect_dev_attributes(mapping: Mapping) -> dict[str, Any]:
                             attr_name, attribute, single_mapping.controller
                         ),
                         format=_tango_display_format(attribute),
-                        polling_period=_tango_polling_period(attribute),
                     )
                 case AttrW():
                     collection[d_attr_name] = server.attribute(
@@ -146,7 +131,6 @@ def _collect_dev_init(mapping: Mapping) -> dict[str, Callable]:
     async def init_device(tango_device: Device):
         await server.Device.init_device(tango_device)  # type: ignore
         tango_device.set_state(DevState.ON)
-        await mapping.controller.connect()
 
     return {"init_device": init_device}
 
@@ -186,13 +170,13 @@ def run(self, options: TangoDSROptions | None = None) -> None:
 
         class_bases = (server.Device,)
         pytango_class = type(options.dev_class, class_bases, class_dict)
-        register_dev(options.dev_name, options.dev_class, options.dsr_instance)
 
         dsr_args = _collect_dsr_args(options)
 
         server.run(
             (pytango_class,),
             [options.dev_class, options.dsr_instance, *dsr_args],
+            green_mode=server.GreenMode.Asyncio,
         )
 
 

tests/backends/tango/compose/compose.yaml

@@ -0,0 +1,22 @@
+# Spin up a local minimal tango cs
+
+version: "3.7"
+services:
+  mysql:
+    image: registry.gitlab.com/tango-controls/docker/mysql:5
+    environment:
+      - MYSQL_ROOT_PASSWORD=root
+
+  tango-cs:
+    hostname: localhost
+    image: registry.gitlab.com/tango-controls/docker/tango-cs:9
+    ports:
+      - "10000:10000"
+    environment:
+      - TANGO_HOST=localhost:10000
+      - MYSQL_HOST=mysql:3306
+      - MYSQL_USER=tango
+      - MYSQL_PASSWORD=tango
+      - MYSQL_DATABASE=tango
+    depends_on:
+      - mysql