Skip to content

Commit ccf0444

Browse files
author
James Souter
committed
remove now unused Attribute.initialise()
1 parent df188b6 commit ccf0444

File tree

3 files changed

+0
-15
lines changed

3 files changed

+0
-15
lines changed

src/fastcs/attributes.py

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,6 @@
44
from collections.abc import Callable
55
from typing import Generic
66

7-
import fastcs
8-
97
from .attribute_io_ref import AttributeIORefT
108
from .datatypes import ATTRIBUTE_TYPES, AttrSetCallback, AttrUpdateCallback, DataType, T
119

@@ -61,9 +59,6 @@ def dtype(self) -> type[T]:
6159
def group(self) -> str | None:
6260
return self._group
6361

64-
async def initialise(self, controller: fastcs.controller.BaseController) -> None:
65-
pass
66-
6762
def add_update_datatype_callback(
6863
self, callback: Callable[[DataType[T]], None]
6964
) -> None:

src/fastcs/controller.py

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
from __future__ import annotations
22

3-
import asyncio
43
from collections import Counter
54
from collections.abc import Sequence
65
from copy import deepcopy
@@ -58,12 +57,6 @@ async def initialise(self):
5857

5958
async def attribute_initialise(self) -> None:
6059
# Initialise any registered handlers for attributes
61-
coros = [attr.initialise(self) for attr in self.attributes.values()]
62-
try:
63-
await asyncio.gather(*coros)
64-
except asyncio.CancelledError:
65-
pass
66-
6760
self._add_io_callbacks()
6861

6962
for controller in self.get_sub_controllers().values():

tests/assertable_controller.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,6 @@
1414
from fastcs.datatypes import Int, T
1515
from fastcs.wrappers import command, scan
1616

17-
# TODO: do we want to have separater ref and AttributeIO classes
18-
# for R and RW/W attributes?
19-
2017

2118
@dataclass
2219
class MyTestAttributeIORef(AttributeIORef):

0 commit comments

Comments
 (0)