Skip to content

Commit ed2964e

Browse files
committed
Fix regression - exceptions in update callbacks should be re-raised
Otherwise they will log exceptions repeatedly
1 parent 8137ed0 commit ed2964e

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

src/fastcs/attributes.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -171,6 +171,7 @@ async def update(self, value: T) -> None:
171171
logger.opt(exception=e).error(
172172
"On update callback failed", attribute=self, value=value
173173
)
174+
raise
174175

175176
def add_on_update_callback(self, callback: AttrOnUpdateCallback[T]) -> None:
176177
"""Add a callback to be called when the value of the attribute is updated

0 commit comments

Comments
 (0)