Replace Controller.get_sub_controllers with Controller.sub_controllers property

Author: GDYendell

src/fastcs/control_system.py

@@ -200,7 +200,7 @@ def _build_controller_api(controller: BaseController, path: list[str]) -> Contro
         command_methods=command_methods,
         sub_apis={
             name: _build_controller_api(sub_controller, path + [name])
-            for name, sub_controller in controller.get_sub_controllers().items()
+            for name, sub_controller in controller.sub_controllers.items()
         },
         description=controller.description,
     )

src/fastcs/controller.py

@@ -67,7 +67,7 @@ def connect_attribute_ios(self) -> None:
             if isinstance(attr, AttrR):
                 attr.set_update_callback(io.update)
 
-        for controller in self.get_sub_controllers().values():
+        for controller in self.sub_controllers.values():
             controller.connect_attribute_ios()
 
     @property
@@ -158,13 +158,16 @@ def add_sub_controller(self, name: str, sub_controller: Controller):
         if isinstance(sub_controller.root_attribute, Attribute):
             self.attributes[name] = sub_controller.root_attribute
 
-    def get_sub_controllers(self) -> dict[str, Controller]:
+    @property
+    def sub_controllers(self) -> dict[str, Controller]:
         return self.__sub_controller_tree
 
     def __repr__(self):
-        return f"""\
-{type(self).__name__}({self.path}, {list(self.__sub_controller_tree.keys())})\
-"""
+        name = self.__class__.__name__
+        path = ".".join(self.path) or None
+        sub_controllers = list(self.sub_controllers.keys()) or None
+
+        return f"{name}(path={path}, sub_controllers={sub_controllers})"
 
     def __setattr__(self, name, value):
         if isinstance(value, Attribute):

tests/test_controller.py

@@ -15,8 +15,8 @@ def test_controller_nesting():
 
     assert sub_controller.path == ["a"]
     assert sub_sub_controller.path == ["a", "b"]
-    assert controller.get_sub_controllers() == {"a": sub_controller}
-    assert sub_controller.get_sub_controllers() == {"b": sub_sub_controller}
+    assert controller.sub_controllers == {"a": sub_controller}
+    assert sub_controller.sub_controllers == {"b": sub_sub_controller}
 
     with pytest.raises(ValueError, match=r"existing sub controller"):
         controller.a = Controller()