Skip to content

Commit 17aea85

Browse files
committed
store unit tests fixed after the refactor
Still to do: 1) store loader needs more unit tests
1 parent 4495095 commit 17aea85

File tree

4 files changed

+41
-185
lines changed

4 files changed

+41
-185
lines changed

dls_barcode/data_store/store.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,7 @@ def backup_records(self, directory):
5454
file_name = time.strftime("%Y-%m-%d_%H-%M-%S", ts)
5555
backup_writer = StoreWriter(directory, file_name)
5656
backup = Backup(backup_writer)
57+
self._sort_records()
5758
backup.backup_records(self.records)
5859

5960
def delete_records(self, records_to_delete):

tests/system_tests/test_unipuck_scan.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
import os, shutil
22

3+
from mock import MagicMock
4+
35
from dls_barcode.config.barcode_config import BarcodeConfig
46
from dls_barcode.data_store import Store
57
from dls_barcode.data_store.store_writer import StoreWriter
@@ -21,7 +23,7 @@
2123
shutil.rmtree(store_dir.value())
2224

2325
comms_manger = StoreWriter(OPTIONS.get_store_directory(), "store")
24-
STORE = Store(comms_manger)
26+
STORE = Store(comms_manger, MagicMock())
2527

2628

2729
def test_generator():

tests/system_tests/test_unipuck_scan_locator.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
import cv2
44
import numpy as np
5+
from mock import MagicMock
56

67
from dls_barcode.config.barcode_config import BarcodeConfig
78
from dls_barcode.data_store import Store
@@ -27,7 +28,8 @@
2728
if os.path.isdir(store_dir.value()):
2829
shutil.rmtree(store_dir.value())
2930
comms_manger = StoreWriter(OPTIONS.get_store_directory(), "store")
30-
STORE = Store(comms_manger)
31+
STORE = Store(comms_manger, MagicMock)
32+
3133
def test_generator():
3234
TEST_CASES = generate_test_cases()
3335
for params in TEST_CASES:

0 commit comments

Comments
 (0)