Skip to content

Commit 66e03bd

Browse files
committed
I04_1-156: prettified messages in UI
1 parent 067b7f1 commit 66e03bd

File tree

3 files changed

+16
-10
lines changed

3 files changed

+16
-10
lines changed

dls_barcode/camera/camera_scanner.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -198,7 +198,8 @@ def _scanner_worker(task_queue, overlay_queue, result_queue, message_queue, kill
198198
plate = scan_result.plate()
199199

200200
if scan_result.already_scanned():
201-
message_queue.put(Message(MessageType.INFO, SCANNED_TAG))
201+
pass
202+
# message_queue.put(Message(MessageType.INFO, SCANNED_TAG))
202203
# overlay_queue.put(TextOverlay(SCANNED_TAG, Color.Green()))
203204
elif scan_result.any_valid_barcodes():
204205
overlay_queue.put(PlateOverlay(plate, config))

dls_barcode/gui/main_window.py

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -75,6 +75,7 @@ def _init_ui(self):
7575

7676
# Message display
7777
self._message_display = MessageDisplay()
78+
self._message_display.setFixedHeight(64)
7879

7980
# Open options first to make sure the cameras are set up correctly.
8081
# Start live capture of the side as soon as the dialog box is closed
@@ -221,11 +222,12 @@ def _read_side_scan(self):
221222

222223
# Barcode successfully read
223224
Beeper.beep()
224-
print("MAIN: side barcode recorded")
225+
print("MAIN: holder barcode recorded")
225226
if self._record_table.unique_side_barcode(plate): # if new side barcode
226-
self._camera_switch.restart_live_capture_from_top()
227227
self.original_plate = plate
228228
self._latest_holder_image = holder_image
229+
self._message_display.display_message(Message(MessageType.INFO, "Plate barcode recorded"))
230+
self._camera_switch.restart_live_capture_from_top()
229231

230232
def _read_top_scan(self):
231233
if self._result_queue.empty():
@@ -245,6 +247,7 @@ def _read_top_scan(self):
245247

246248
# Barcodes successfully read
247249
Beeper.beep()
248-
print("Scan Recorded")
250+
print("Scan Completed")
251+
self._message_display.display_message(Message(MessageType.INFO, "Scan completed"))
249252
self._camera_switch.restart_live_capture_from_side()
250253

dls_barcode/gui/message_display.py

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3,19 +3,21 @@
33

44
from dls_util.message import MessageType
55

6+
RED = "; color: red"
7+
BLACK = "; color: black"
8+
BASIC_STYLE_SHEET = "font-size: 14pt"
69

710
class MessageDisplay(QGroupBox):
811
"""GUI component. Displays messages for the user."""
9-
RED = "red"
10-
BLACK = "black"
12+
1113

1214
def __init__(self):
1315
super(MessageDisplay, self).__init__()
1416

1517
self.setTitle("Information")
1618

17-
self._colors = {MessageType.INFO: "black",
18-
MessageType.WARNING: "red"}
19+
self._style_sheets = {MessageType.INFO: BASIC_STYLE_SHEET + BLACK,
20+
MessageType.WARNING: BASIC_STYLE_SHEET + RED}
1921
self._init_ui()
2022

2123
# Start a timer to clear old messages
@@ -25,7 +27,7 @@ def __init__(self):
2527

2628
def _init_ui(self):
2729
self._message_lbl = QLabel()
28-
self._message_lbl.setStyleSheet("color: red")
30+
self._message_lbl.setStyleSheet(BASIC_STYLE_SHEET)
2931

3032
vbox = QVBoxLayout()
3133
vbox.addWidget(self._message_lbl)
@@ -35,7 +37,7 @@ def _init_ui(self):
3537
def display_message(self, message):
3638
self._message = message
3739
self._message_lbl.setText(self._message.content())
38-
self._message_lbl.setStyleSheet("color: " + self._colors[self._message.type()])
40+
self._message_lbl.setStyleSheet(self._style_sheets[self._message.type()])
3941

4042
def _clear_old_message(self):
4143
if self._message_lbl.text() and self._message.has_expired():

0 commit comments

Comments
 (0)