Backup - update

build bat update

Author: UrszulaNeuman

build.bat

@@ -6,7 +6,7 @@ cd dls_barcode
 REM use to debug the exe file
 REM pyinstaller --onefile --icon=..\resources\icons\qr_code.ico --debug --clean main.py
 
-pyinstaller --onefile --windowed --icon="C:\Users\rqq82173\PycharmProjects\PuckBarcodeReader\resources\icons\qr_code.ico" --add-data "C:\Users\rqq82173\PycharmProjects\PuckBarcodeReader\resources; C:\Users\rqq82173\PycharmProjects\PuckBarcodeReader\bin" --clean "C:\Users\rqq82173\PycharmProjects\PuckBarcodeReader\dls_barcode\main.py"
+pyinstaller --onefile --windowed --icon="C:\Users\rqq82173\PycharmProjects\PuckBarcodeReader\resources\icons\qr_code.ico" --clean "C:\Users\rqq82173\PycharmProjects\PuckBarcodeReader\dls_barcode\main.py"
 
 move dist\main.exe ..\bin\barcode.exe
 rd /S /Q build

dls_barcode/data_store/backup.py

@@ -9,16 +9,15 @@ class Backup:
     Backup class maintains the short time backaup of records which is kept in the same folder as the store files.
     """
 
+    WEEK_IN_SECONDS = 604800
+
     def __init__(self, comms_man, backup_time):
         self._comms = comms_man
         self._backup_time = backup_time.value()
         self._records = self._comms.load_records_from_file()
-        self._truncate_record_list()
 
     def _truncate_record_list(self):
-        for record in self._records:
-            if self._is_old(record):
-                self._records.remove(record)
+        self._records = list(filter(lambda x: not self._is_old(x), self._records))
 
     def backup_records(self, to_back):
         self._records.extend(to_back)
@@ -29,6 +28,6 @@ def _is_old(self, record):
         tm = time.time()
         record_time = record.timestamp
         delta = tm - record_time
-        weeks = self._backup_time * 604800  # weeks in seconds
+        weeks = self._backup_time * self.WEEK_IN_SECONDS  # weeks in seconds
         return delta > weeks