Store records should be truncated with every change

Author: IsabellaRey

dls_barcode/data_store/record.py

@@ -126,13 +126,13 @@ def to_string(self):
     def _all_barcodes(self):
         return [self.holder_barcode] + self.barcodes
 
-    def image(self):
+    def _image(self):
         image = Image.from_file(self.image_path)
         return image
 
     def marked_image(self, options):
         geo = self.geometry
-        image = self.image()
+        image = self._image()
 
         if options.image_puck.value():
             geo.draw_plate(image, Color.Blue())

dls_barcode/data_store/store.py

@@ -64,7 +64,6 @@ def _add_record(self, holder_barcode, plate, holder_img, pins_img):
 
         self.records.append(record)
         self._process_change()
-        self._truncate_record_list()
 
     def merge_record(self, holder_barcode, plate, holder_img, pins_img):
         """ Create new record or replace existing record if it has the same holder barcode as the most
@@ -86,17 +85,18 @@ def delete_records(self, records_to_delete):
         self._process_change()
 
     def _truncate_record_list(self):
-        number = self._store_capacity.value()
-        number = max(number, 2)
+        min_store_capacity = 2
+        actual_store_capacity = max(self._store_capacity.value(), min_store_capacity)
 
-        if len(self.records) > number:
-            to_delete = self.records[number:]
+        if len(self.records) > actual_store_capacity:
+            to_delete = self.records[actual_store_capacity:]
             self.delete_records(to_delete)
 
     def _process_change(self):
         """ Sort the records and save to file.
         """
         self._sort_records()
+        self._truncate_record_list()
         self._to_file()
         self._to_csv_file()