Skip to content

Commit 4a1884b

Browse files
ndg63276Mark Williams
andauthored
LIMS-1066: Autofill UDC visit on dispatch form (#881)
Co-authored-by: Mark Williams <mark.williams@diamond.ac.uk>
1 parent 92289a0 commit 4a1884b

File tree

2 files changed

+21
-7
lines changed

2 files changed

+21
-7
lines changed

api/src/Page/Shipment.php

Lines changed: 18 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1642,12 +1642,24 @@ function _get_dewars()
16421642
$order = $cols[$this->arg('sort_by')] . ' ' . $dir;
16431643
}
16441644

1645-
$dewars = $this->db->paginate("SELECT CONCAT(p.proposalcode, p.proposalnumber) as prop, CONCAT(p.proposalcode, p.proposalnumber, '-', se.visit_number) as firstexperiment, r.labcontactid, se.beamlineoperator as localcontact, se.beamlinename, TO_CHAR(se.startdate, 'HH24:MI DD-MM-YYYY') as firstexperimentst, d.firstexperimentid, s.shippingid, s.shippingname, d.facilitycode, count(c.containerid) as ccount, (case when se.visit_number > 0 then (CONCAT(p.proposalcode, p.proposalnumber, '-', se.visit_number)) else '' end) as exp, d.code, d.barcode, d.storagelocation, d.dewarstatus, d.dewarid, d.trackingnumbertosynchrotron, d.trackingnumberfromsynchrotron, d.externalShippingIdFromSynchrotron, s.deliveryagent_agentname, d.weight, d.deliveryagent_barcode, GROUP_CONCAT(c.code SEPARATOR ', ') as containers, s.sendinglabcontactid, s.returnlabcontactid, pe.givenname, pe.familyname, s.safetylevel as shippingsafetylevel
1646-
FROM dewar d
1647-
LEFT OUTER JOIN container c ON c.dewarid = d.dewarid
1648-
INNER JOIN shipping s ON d.shippingid = s.shippingid
1649-
INNER JOIN proposal p ON p.proposalid = s.proposalid
1650-
LEFT OUTER JOIN blsession se ON d.firstexperimentid = se.sessionid
1645+
$dewars = $this->db->paginate("SELECT
1646+
CONCAT(p.proposalcode, p.proposalnumber) as prop,
1647+
CONCAT(p.proposalcode, p.proposalnumber, '-', se.visit_number) as firstexperiment,
1648+
CONCAT(p.proposalcode, p.proposalnumber, '-', se2.visit_number) as udcfirstexperiment,
1649+
r.labcontactid, se.beamlineoperator as localcontact, se.beamlinename,
1650+
TO_CHAR(se.startdate, 'HH24:MI DD-MM-YYYY') as firstexperimentst, d.firstexperimentid,
1651+
s.shippingid, s.shippingname, d.facilitycode, count(c.containerid) as ccount,
1652+
(case when se.visit_number > 0 then (CONCAT(p.proposalcode, p.proposalnumber, '-', se.visit_number)) else '' end) as exp,
1653+
d.code, d.barcode, d.storagelocation, d.dewarstatus, d.dewarid,
1654+
d.trackingnumbertosynchrotron, d.trackingnumberfromsynchrotron, d.externalShippingIdFromSynchrotron,
1655+
s.deliveryagent_agentname, d.weight, d.deliveryagent_barcode, GROUP_CONCAT(c.code SEPARATOR ', ') as containers,
1656+
s.sendinglabcontactid, s.returnlabcontactid, pe.givenname, pe.familyname, s.safetylevel as shippingsafetylevel
1657+
FROM dewar d
1658+
LEFT OUTER JOIN container c ON c.dewarid = d.dewarid
1659+
INNER JOIN shipping s ON d.shippingid = s.shippingid
1660+
INNER JOIN proposal p ON p.proposalid = s.proposalid
1661+
LEFT OUTER JOIN blsession se ON d.firstexperimentid = se.sessionid
1662+
LEFT OUTER JOIN blsession se2 ON c.sessionid = se2.sessionid
16511663
LEFT OUTER JOIN dewarregistry r ON r.facilitycode = d.facilitycode
16521664
LEFT OUTER JOIN labcontact lc ON s.sendinglabcontactid = lc.labcontactid
16531665
LEFT OUTER JOIN person pe ON lc.personid = pe.personid

client/src/js/modules/shipment/views/dispatch.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -112,6 +112,7 @@ define(['marionette', 'views/form',
112112
DEWARID: this.getOption('dewar').get('DEWARID'),
113113
LABCONTACTID: this.getOption('dewar').get('LABCONTACTID'),
114114
VISIT: this.getOption('dewar').get('FIRSTEXPERIMENT'),
115+
UDCVISIT: this.getOption('dewar').get('UDCFIRSTEXPERIMENT'),
115116
// If no agent specified on inbound, default to diamond dhl
116117
DELIVERYAGENT_AGENTNAME: this.getOption('shipping').get('DELIVERYAGENT_AGENTNAME') || 'DHL'
117118
})
@@ -174,7 +175,8 @@ define(['marionette', 'views/form',
174175
},
175176

176177
doOnRender: function() {
177-
this.ui.exp.html(this.visits.opts()).val(this.model.get('VISIT'))
178+
let visit = this.model.get('VISIT') || this.model.get('UDCVISIT')
179+
this.ui.exp.html(this.visits.opts()).val(visit)
178180
this.updateLC()
179181
this.populateCountries()
180182
this.stripPostCode()

0 commit comments

Comments
 (0)