-
Notifications
You must be signed in to change notification settings - Fork 6
Open
Labels
bugSomething isn't workingSomething isn't working
Description
Pending #1210 it will be impossible to call prepare outside of a run with our current setup because prepare eventually calls the path provider, which depends on the state that is the current run.
sequenceDiagram
plan->>+RE: prepare()
RE->>+detector: prepare()
detector->>+writer: arm()
writer->>+path_provier: __call__()
path_provier->>+writer: path (from numtracker, dependant on current run)
writer->>+ioc: set_path(path)
writer->>+ioc: open()
writer->>-detector:
detector->>-RE:
RE->>-plan:
This issue is to discuss if we actually want that behaviour long-term
Steps To Reproduce
Steps to reproduce the behaviour:
- Fix
StartDocumentPathProviderdoes not clear its state after a run #1210 - See that you can now never call
prepareoutside of a run
Acceptance Criteria
- Either
preparedoes not depend on the current state that is the runpreparegives a very clear error message when called outside of a run
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working