reply review

Author: eir17846

src/daq_config_server/models/converters/_file_converter_map.py

@@ -41,5 +41,5 @@
     "/dls_sw/i03/software/daq_configuration/lookup/BeamLineEnergy_DCM_Pitch_converter.txt": beamline_pitch_lut,  # noqa
     "/dls_sw/i03/software/daq_configuration/lookup/BeamLineEnergy_DCM_Roll_converter.txt": beamline_roll_lut,  # noqa
     "/dls_sw/i03/software/daq_configuration/lookup/BeamLine_Undulator_toGap.txt": undulator_energy_gap_lut,  # noqa
-    "IIDCalibrationTable.txt": i09_hu_undulator_energy_gap_lut,  # noga
+    "/dls_sw/i09-1/software/gda/workspace_git/gda-diamond.git/configurations/i09-1-shared/lookupTables/IIDCalibrationTable.txt": i09_hu_undulator_energy_gap_lut,  # noqa: E501
 }

src/daq_config_server/models/converters/lookup_tables/_converters.py

@@ -4,7 +4,7 @@
 
 from ._models import GenericLookupTable
 
-ignore_lines_starting_with = ("Units", "ScannableUnits", "ScannableNames")
+IGNORE_LINES_STARTING_WITH = ("Units", "ScannableUnits", "ScannableNames")
 
 
 def parse_lut(contents: str, *params: tuple[str, type | None]) -> GenericLookupTable:
@@ -20,7 +20,7 @@ def parse_lut(contents: str, *params: tuple[str, type | None]) -> GenericLookupT
     column_names = [param[0] for param in params]
     types = [param[1] for param in params]
     for line in remove_comments(contents.splitlines()):
-        if line.startswith(ignore_lines_starting_with):
+        if line.startswith(IGNORE_LINES_STARTING_WITH):
             continue
         rows.append(
             [parse_value(value, types[i]) for i, value in enumerate(line.split())]