removes all isolation level stuff

Author: David Erb

src/dls_normsql/aiosqlite.py

@@ -71,66 +71,6 @@ def __init__(self, specification, database_definition_object):
         # Last undo position.
         self.__last_restore = 0
 
-    # ----------------------------------------------------------------------------------------
-    async def __get_isolation_level(self):
-        # Read the current isolation level
-        cursor = await self.__connection.execute("PRAGMA isolation_level")
-        result = await cursor.fetchone()
-
-        logger.debug(describe("result", result))
-
-        if result is None:
-            isolation_level = ""
-        else:
-            isolation_level = result[0]
-
-        return isolation_level
-
-    # ----------------------------------------------------------------------------------------
-    async def __set_isolation_level(self):
-        """
-        Set the isolation level on the connection.
-
-        Set isolation level such that all statements which are not already in an explicit transaction
-        are autocommitted immediately and visible on other connections.
-        This might be less efficient?  But it's nice when monitoring a sqlite file with a management tool.
-        TODO: Consider the ramifications of setting aiosqlite isolation_level to None.
-        """
-
-        # Possible values are None, '' (default), DEFERRED, and EXCLUSIVE.
-        # Default if not mentioned in the configuration is None.
-        configured_isolation_level = self.__type_specific_tbd.get("isolation_level", "")
-        previous_isolation_level = await self.__get_isolation_level()
-
-        logger.debug(describe("previous_isolation_level", previous_isolation_level))
-
-        if configured_isolation_level == previous_isolation_level:
-            logger.debug(
-                f"isolation_level is already the configured '{configured_isolation_level}'"
-            )
-        else:
-            logger.debug(
-                f"isolation_level is needs to be set from '{previous_isolation_level}' to '{configured_isolation_level}'"
-            )
-
-            if configured_isolation_level is None:
-                await self.execute("PRAGMA isolation_level =")
-            else:
-                await self.execute(
-                    f"PRAGMA isolation_level = {configured_isolation_level}"
-                )
-            await self.commit()
-
-            readback_isolation_level = await self.__get_isolation_level()
-
-            if readback_isolation_level != configured_isolation_level:
-                raise RuntimeError(
-                    f"readback isolation level '{readback_isolation_level}' does not match '{configured_isolation_level}' as was set"
-                )
-            logger.debug(
-                f"isolation_level is now set from '{previous_isolation_level}' to '{readback_isolation_level}'"
-            )
-
     # ----------------------------------------------------------------------------------------
     async def connect(self, should_drop_database=False):
         """
@@ -152,31 +92,6 @@ async def connect(self, should_drop_database=False):
             self.__connection = await aiosqlite.connect(self.__filename)
             self.__connection.row_factory = aiosqlite.Row
 
-            # Set isolation level such that all statements which are not already in an explicit transaction
-            # are autocommitted immediately and visible on other connections.
-            # This might be less efficient?  But it's nice when monitoring a sqlite file with a management tool.
-            # TODO: Consider the ramifications of setting aiosqlite isolation_level to None.
-            # Possible values are None, '' (default), DEFERRED, and EXCLUSIVE.
-            logger.debug(
-                f"isolation_level was set to '{self.__connection.isolation_level}'"
-            )
-            isolation_level = self.__type_specific_tbd.get("isolation_level", None)
-            # self.__connection.isolation_level = isolation_level
-            logger.debug(
-                f"isolation_level is now set to '{self.__connection.isolation_level}'"
-            )
-
-            # rows = await self.query("PRAGMA journal_mode", why="query journal mode")
-            # logger.debug(f"journal mode rows {json.dumps(rows)}")
-
-            # rows = await self.query("PRAGMA journal_mode=OFF", why="turn OFF journal mode")
-            # logger.debug(f"journal mode OFF rows {json.dumps(rows)}")
-
-            # rows = await self.query("PRAGMA journal_mode", why="query journal mode")
-            # logger.debug(f"journal mode rows {json.dumps(rows)}")
-
-            # rows = await self.query("SELECT * from mainTable", why="main table check")
-
             await self.__connection.create_function("regexp", 2, sqlite_regexp_callback)
 
             # Let the base class contribute its table definitions to the in-memory list.
@@ -262,6 +177,9 @@ async def apply_revision(self, revision):
     async def disconnect(self):
 
         if self.__connection is not None:
+            # Commit any uncommitted transactions.
+            await self.commit()
+
             logger.debug(f"[DISSHU] {callsign(self)} disconnecting")
             await self.__connection.close()
             self.__connection = None