Skip to content

Commit 080f074

Browse files
committed
Enough tests to get full coverage
Maybe enough tests to cover basic use
1 parent e0dcac9 commit 080f074

File tree

2 files changed

+348
-87
lines changed

2 files changed

+348
-87
lines changed

src/dodal/device_manager.py

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -199,7 +199,7 @@ def __init__(
199199
skip: SkipType,
200200
wait: bool,
201201
timeout: int,
202-
init: OphydInitialiser[V1] | None,
202+
init: OphydInitialiser[V1],
203203
manager: "DeviceManager",
204204
):
205205
self.factory = factory
@@ -210,8 +210,7 @@ def __init__(
210210
self.timeout = timeout
211211
self.post_create = init or (lambda x: x)
212212
self._manager = manager
213-
if init:
214-
wraps(init)(self)
213+
wraps(init)(self)
215214

216215
@property
217216
def name(self) -> str:
@@ -280,7 +279,7 @@ def build(self, mock: bool = False, fixtures: dict[str, Any] | None = None) -> V
280279
return device # type: ignore - it's us really, promise
281280

282281
def __repr__(self) -> str:
283-
return f"<{self.name}: V1DeviceFactory({self.factory.__name__})>"
282+
return f"<{self.name}: V1DeviceFactory[{self.factory.__name__}]>"
284283

285284

286285
class ConnectionSpec(NamedTuple):
@@ -607,5 +606,8 @@ def _build_order(
607606

608607
return order
609608

609+
def __len__(self) -> int:
610+
return len(self._factories) + len(self._v1_factories)
611+
610612
def __repr__(self) -> str:
611-
return f"<DeviceManager: {len(self._factories)} devices>"
613+
return f"<DeviceManager: {len(self)} devices>"

0 commit comments

Comments
 (0)