add tests for scint in

Author: srishtysajeev

tests/devices/test_scintillator.py

@@ -46,6 +46,7 @@ async def scintillator_and_ap_sg(
 @pytest.mark.parametrize(
     "y, z, expected_position",
     [
+        (100.855, 101.5115, InOut.IN),
         (-0.02, 0.1, InOut.OUT),
         (0.1, 0.1, InOut.UNKNOWN),
         (10.2, 15.6, InOut.UNKNOWN),
@@ -84,6 +85,11 @@ async def test_given_aperture_scatterguard_parked_when_set_to_out_position_then_
     assert await scintillator.y_mm.user_setpoint.get_value() == -0.02
     assert await scintillator.z_mm.user_setpoint.get_value() == 0.1
 
+    await scintillator.selected_pos.set(InOut.IN)
+
+    assert await scintillator.y_mm.user_setpoint.get_value() == -100.855
+    assert await scintillator.z_mm.user_setpoint.get_value() == 101.5115
+
 
 async def test_given_aperture_scatterguard_not_parked_when_set_to_out_position_then_exception_raised(
     scintillator_and_ap_sg: tuple[Scintillator, ApertureScatterguard],
@@ -92,6 +98,8 @@ async def test_given_aperture_scatterguard_not_parked_when_set_to_out_position_t
         if position != ApertureValue.PARKED:
             scintillator, ap_sg = scintillator_and_ap_sg
             ap_sg.return_value.selected_aperture.get_value.return_value = position  # type: ignore
-
+            # there is no assert so why does this work
             with pytest.raises(ValueError):
                 await scintillator.selected_pos.set(InOut.OUT)
+            with pytest.raises(ValueError):
+                await scintillator.selected_pos.set(InOut.IN)