Skip to content

Commit 50e7221

Browse files
fix typo
1 parent 649a5aa commit 50e7221

File tree

2 files changed

+5
-6
lines changed

2 files changed

+5
-6
lines changed

src/dodal/devices/i24/commissioning_jungfrau.py

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
from dodal.log import LOGGER
2222

2323

24-
class JunfrauCommissioningWriter(DetectorWriter, StandardReadable):
24+
class JungfrauCommissioningWriter(DetectorWriter, StandardReadable):
2525
"""Implementation of the temporary filewriter used for Jungfrau commissioning on i24.
2626
2727
The PVs on this device are responsible for writing files of a specified name
@@ -48,7 +48,6 @@ async def open(self, name: str, exposures_per_event: int = 1) -> dict[str, DataK
4848
self._exposures_per_event = exposures_per_event
4949
_path_info = self._path_provider()
5050

51-
# Commissioning Jungfrau plans allow you to override path, so check to see if file exists
5251
requested_filepath = Path(_path_info.directory_path) / _path_info.filename
5352
if requested_filepath.exists():
5453
raise FileExistsError(
@@ -99,7 +98,7 @@ async def close(self) -> None: ...
9998

10099

101100
class CommissioningJungfrau(
102-
StandardDetector[JungfrauController, JunfrauCommissioningWriter]
101+
StandardDetector[JungfrauController, JungfrauCommissioningWriter]
103102
):
104103
"""Ophyd-async implementation of a Jungfrau 9M Detector, using a temporary
105104
filewriter in place of Odin"""
@@ -112,7 +111,7 @@ def __init__(
112111
name="",
113112
):
114113
self.drv = JungfrauDriverIO(prefix)
115-
writer = JunfrauCommissioningWriter(writer_prefix, path_provider)
114+
writer = JungfrauCommissioningWriter(writer_prefix, path_provider)
116115
controller = JungfrauController(self.drv)
117116
super().__init__(controller, writer, name=name)
118117

tests/devices/i24/test_commissioning_jungfrau.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ async def test_jungfrau_with_temporary_writer(
3030
):
3131
set_mock_value(jungfrau._writer.writer_ready, 1)
3232
set_mock_value(jungfrau._writer.frame_counter, 10)
33-
jungfrau._writer._path_info = MagicMock()
33+
jungfrau._writer._path_provider = MagicMock()
3434
trigger_info = TriggerInfo(livetime=1e-3, exposures_per_event=5)
3535
await jungfrau.prepare(trigger_info)
3636
assert await jungfrau._writer.frame_counter.get_value() == 0
@@ -48,7 +48,7 @@ async def _do_fake_writing():
4848
set_mock_value(jungfrau._writer.frame_counter, 5)
4949

5050
await asyncio.gather(status, _do_fake_writing())
51-
jungfrau._writer._path_info.assert_called_once()
51+
jungfrau._writer._path_provider.assert_called_once()
5252

5353

5454
async def test_jungfrau_error_when_writing_to_existing_file(tmp_path: Path):

0 commit comments

Comments
 (0)