Fix so that patched motor dial limits are not none (#1717)

Author: DominicOram

pyproject.toml

@@ -14,7 +14,7 @@ description = "Ophyd devices and other utils that could be used across DLS beaml
 dependencies = [
     "click",
     "ophyd",
-    "ophyd-async[ca,pva]>=0.13.5",
+    "ophyd-async[ca,pva]>=0.13.7",
     "bluesky>=1.14.5",
     "pyepics",
     "dataclasses-json",

src/dodal/testing/setup.py

@@ -39,6 +39,8 @@ def patch_motor(
     set_mock_value(motor.max_velocity, max_velocity)
     set_mock_value(motor.low_limit_travel, low_limit_travel)
     set_mock_value(motor.high_limit_travel, high_limit_travel)
+    set_mock_value(motor.dial_low_limit_travel, low_limit_travel)
+    set_mock_value(motor.dial_high_limit_travel, high_limit_travel)
     return callback_on_mock_put(
         motor.user_setpoint,
         lambda pos, *args, **kwargs: set_mock_value(motor.user_readback, pos),

tests/devices/test_smargon.py

@@ -108,18 +108,16 @@ async def test_given_center_disp_low_when_stub_offsets_set_to_center_and_moved_t
 async def test_given_set_with_value_outside_motor_limit(
     smargon: Smargon, test_x, test_y, test_z, test_omega, test_chi, test_phi
 ):
-    set_mock_value(smargon.x.low_limit_travel, -1999)
-    set_mock_value(smargon.y.low_limit_travel, -1999)
-    set_mock_value(smargon.z.low_limit_travel, -1999)
-    set_mock_value(smargon.omega.low_limit_travel, -1999)
-    set_mock_value(smargon.chi.low_limit_travel, -1999)
-    set_mock_value(smargon.phi.low_limit_travel, -1999)
-    set_mock_value(smargon.x.high_limit_travel, 1999)
-    set_mock_value(smargon.y.high_limit_travel, 1999)
-    set_mock_value(smargon.z.high_limit_travel, 1999)
-    set_mock_value(smargon.omega.high_limit_travel, 1999)
-    set_mock_value(smargon.chi.high_limit_travel, 1999)
-    set_mock_value(smargon.phi.high_limit_travel, 1999)
+    for motor in [
+        smargon.x,
+        smargon.y,
+        smargon.z,
+        smargon.omega,
+        smargon.chi,
+        smargon.phi,
+    ]:
+        set_mock_value(motor.low_limit_travel, -1999)
+        set_mock_value(motor.high_limit_travel, 1999)
 
     with pytest.raises(MotorLimitsError):
         await smargon.set(