Add or_raise method to DeviceBuildResult

Author: tpoliaw

src/dodal/device_manager.py

@@ -282,14 +282,10 @@ def build(self, mock: bool = False, fixtures: dict[str, Any] | None = None) -> V
             self,
             fixtures=fixtures,
             mock=mock,
-        )
-        if devices.errors:
-            # TODO: NotBuilt?
-            raise Exception("??? build")
-        else:
-            device = devices.devices[self.name].device
-            return device  # type: ignore - it's us really, promise
+        ).or_raise()
 
+        device = devices.devices[self.name].device
+        return device  # type: ignore - it's us really, promise
 
 
 class ConnectionSpec(NamedTuple):
@@ -342,6 +338,13 @@ def connect(self, timeout: float | None = None) -> ConnectionResult:
 
         return ConnectionResult(connected, self.errors, connection_errors)
 
+    def or_raise(self) -> Self:
+        if self.errors:
+            for name, exc in self.errors.items():
+                exc.add_note(name)
+            raise ExceptionGroup("Some devices failed", tuple(self.errors.values()))
+        return self
+
 
 class DeviceManager:
     _factories: dict[str, DeviceFactory]