Skip to content

Commit 87ded47

Browse files
committed
Clean up TODO comments
1 parent 15142a8 commit 87ded47

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

src/dodal/device_manager.py

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -167,7 +167,7 @@ def build(
167167
return device # type: ignore - it's us, honest
168168

169169
def create(self, *args, **kwargs) -> V2:
170-
# TODO: Remove when v1 support is no longer required
170+
# TODO: Remove when v1 support is no longer required - see #1718
171171
return self(*args, **kwargs)
172172

173173
def __call__(self, *args, **kwargs) -> V2:
@@ -181,7 +181,7 @@ def __repr__(self) -> str:
181181
return f"<{self.name}: DeviceFactory{params}>"
182182

183183

184-
# TODO: Remove when ophyd v1 support is no longer required
184+
# TODO: Remove when ophyd v1 support is no longer required - see #1718
185185
class V1DeviceFactory(Generic[V1]):
186186
"""
187187
Wrapper around an ophyd v1 device that holds a reference to a device
@@ -240,7 +240,7 @@ def skip(self) -> bool:
240240
return self._skip() if callable(self._skip) else self._skip
241241

242242
def mock_if_needed(self, mock=False) -> Self:
243-
# TODO: Remove when Ophyd V1 support is no longer required
243+
# TODO: Remove when Ophyd V1 support is no longer required - see #1718
244244
factory = (
245245
make_fake_device(self.factory) if (self.mock or mock) else self.factory
246246
)
@@ -320,7 +320,7 @@ def connect(self, timeout: float | None = None) -> ConnectionResult:
320320
loop: asyncio.EventLoop = get_bluesky_event_loop() # type: ignore
321321
for name, device in self.devices.items():
322322
if not isinstance(device, OphydV2Device):
323-
# TODO: Remove when ophyd v1 support is no longer required
323+
# TODO: Remove when ophyd v1 support is no longer required - see #1718
324324
# V1 devices are connected at creation time assuming wait is not set to False
325325
connected[name] = device
326326
continue
@@ -513,7 +513,7 @@ def build_devices(
513513
}
514514
try:
515515
if isinstance(factory, V1DeviceFactory):
516-
# TODO: Remove when ophyd v1 support is no longer required
516+
# TODO: Remove when ophyd v1 support is no longer required - see #1718
517517
factory = factory.mock_if_needed(mock)
518518
built_device = factory.create(**params)
519519
built[device] = built_device
@@ -577,8 +577,8 @@ def _build_order(
577577
given factory list.
578578
"""
579579

580-
# TODO: This is not an efficient way of doing this
581-
# However, for realistic use cases, it is fast enough for now
580+
# This is not an efficient way of doing this, however, for realistic use
581+
# cases, it is fast enough for now
582582
order = []
583583
available = set(fixtures.keys())
584584
pending = factories

0 commit comments

Comments
 (0)