refactor: change error message so it's not specific to just out

srishtysajeev · srishtysajeev · commit 9f52097ed768 · 2025-11-17T10:38:26.000Z
diff --git a/src/dodal/devices/scintillator.py b/src/dodal/devices/scintillator.py
@@ -85,7 +85,7 @@ async def _check_aperture_parked(self):
             != ApertureValue.PARKED
         ):
             raise ValueError(
-                f"Cannot move scintillator out if aperture/scatterguard is not parked. Position is currently {await self._aperture_scatterguard().selected_aperture.get_value()}"
+                f"Cannot move scintillator if aperture/scatterguard is not parked. Position is currently {await self._aperture_scatterguard().selected_aperture.get_value()}"
             )
 
     async def _set_selected_position(self, position: InOut) -> None:

Original file line number	Diff line number	Diff line change
`@@ -85,7 +85,7 @@ async def _check_aperture_parked(self):`
`85`	`85`	`!= ApertureValue.PARKED`
`86`	`86`	`):`
`87`	`87`	`raise ValueError(`
`88`		`- f"Cannot move scintillator out if aperture/scatterguard is not parked. Position is currently {await self._aperture_scatterguard().selected_aperture.get_value()}"`
	`88`	`+ f"Cannot move scintillator if aperture/scatterguard is not parked. Position is currently {await self._aperture_scatterguard().selected_aperture.get_value()}"`
`89`	`89`	`)`
`90`	`90`
`91`	`91`	`async def _set_selected_position(self, position: InOut) -> None:`