Remove debugging and commented code

Author: tpoliaw

src/dodal/beamlines/adsim.py

@@ -90,4 +90,5 @@ def det(path_provider: PathProvider) -> SimDetector:
 
 @devices.v1_init(factory=EpicsMotor, prefix=f"{PREFIX.beamline_prefix}-MO-SIMC-01:M1")
 def old_motor(motor: EpicsMotor):
-    print(f"Built {motor}")
+    # arbitrary post-init configuration
+    motor.settle_time = 12

src/dodal/device_manager.py

@@ -63,8 +63,8 @@ def __init__(
         provided: Mapping[str, Any] | None,
         factories: Mapping[str, Callable[[], Any]],
     ):
-        self.ready = dict(provided or {})
         # wrap to prevent modification escaping
+        self.ready = dict(provided or {})
         # drop duplicate keys so the len and iter methods are easier
         self.lazy = {k: v for k, v in factories.items() if k not in self.ready}
 
@@ -166,7 +166,6 @@ def build(
         )
         if devices.errors:
             # TODO: NotBuilt?
-            print(devices.errors)
             raise Exception("??? build")
         else:
             if connect_immediately:
@@ -286,7 +285,6 @@ def build(self, mock: bool = False, fixtures: dict[str, Any] | None = None) -> V
         )
         if devices.errors:
             # TODO: NotBuilt?
-            print(devices.errors)
             raise Exception("??? build")
         else:
             device = devices.devices[self.name].device
@@ -366,7 +364,6 @@ def fixture(self, func: Callable[[], T]) -> Callable[[], T]:
     def v1_init(
         self,
         factory: type[V1],
-        # name: str,
         prefix: str,
         mock: bool = False,
         skip: SkipType = False,
@@ -479,10 +476,7 @@ def build_devices(
                 f"Factories ({common}) will be overridden by fixtures", stacklevel=1
             )
             factories = tuple(f for f in factories if f.name not in common)
-        # if unknown := {f for f in factories if f not in self._factories.values()}:
-        #     raise ValueError(f"Factories ({unknown}) are unknown to this manager")
         build_list = self._expand_dependencies(factories, fixtures)
-        # print(build_list)
         order = self._build_order(
             {dep: self[dep] for dep in build_list}, fixtures=fixtures
         )
@@ -544,13 +538,10 @@ def _expand_dependencies(
         dependencies = set()
         factories = set(factories)
         while factories:
-            # print(dependencies)
             fact = factories.pop()
             dependencies.add(fact.name)
             options = fact.optional_dependencies
-            # print(f"  {fact.name}")
             for dep in fact.dependencies:
-                # print(f"    {dep}")
                 if dep not in dependencies and dep not in available_fixtures:
                     if dep in self._factories:
                         factories.add(self[dep])