Skip to content

Conversation

@rtuck99
Copy link
Contributor

@rtuck99 rtuck99 commented Oct 21, 2025

Part of

Required for

This makes the name argument optional for inject(); when used with a device composite the names of the individual devices in the composite are determined from the field names, and the name of the composite itself does not correspond to anything.

Instructions to reviewer on how to test:

  1. Tests pass

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

@rtuck99 rtuck99 marked this pull request as ready for review October 21, 2025 09:27
@rtuck99 rtuck99 requested a review from a team as a code owner October 21, 2025 09:27
@codecov
Copy link

codecov bot commented Oct 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.10%. Comparing base (ba7f9ce) to head (03342d9).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1649   +/-   ##
=======================================
  Coverage   99.10%   99.10%           
=======================================
  Files         280      280           
  Lines       10518    10518           
=======================================
  Hits        10424    10424           
  Misses         94       94           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@jacob720 jacob720 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@rtuck99 rtuck99 enabled auto-merge (squash) December 4, 2025 16:45
@rtuck99 rtuck99 merged commit 8e12cb6 into main Dec 4, 2025
10 checks passed
@rtuck99 rtuck99 deleted the inject_no_args branch December 4, 2025 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants