Handle parameters starting with numbers and convert them to valid names #71
Description
Currently parameters are failing in two ways:
WARNING:root:Removing parameters with invalid names: ['0/status/decoder/name']
WARNING:root:Removing parameters with invalid names: ['1/status/decoder/name']
WARNING:root:Removing parameters with invalid names: ['2/status/decoder/name']
WARNING:root:Removing parameters with invalid names: ['3/status/decoder/name']
Invalid name:
1 validation error for SignalR
name
String should match pattern '^([A-Z][a-z0-9]*)*$' [type=string_pattern_mismatch, input_value='0StatusTimestamp', input_type=str]
For further information visit https://errors.pydantic.dev/2.10/v/string_pattern_mismatch
Invalid name:
1 validation error for SignalR
name
String should match pattern '^([A-Z][a-z0-9]*)*$' [type=string_pattern_mismatch, input_value='0StatusError', input_type=str]
For further information visit https://errors.pydantic.dev/2.10/v/string_pattern_mismatch
Invalid name:
1 validation error for SignalR
name
String should match pattern '^([A-Z][a-z0-9]*)*$' [type=string_pattern_mismatch, input_value='0StatusConnected', input_type=str]
For further information visit https://errors.pydantic.dev/2.10/v/string_pattern_mismatch
The simplest fix would be to intercept these values during introspection and add a string to the front to make it valid, or move the number to the end. Also these parameters should have Status and Config removed from them to shorten the PVs.
Note the same applies to group names:
2025-05-29T16:03:23.504146465 WARN pvxs.ioc.group.processor
Group GARYI04:FR:FR0:DECODER:PVI defines no +trigger mappings. Default to individual/split monitor updates.
2025-05-29T16:03:23.505063821 WARN pvxs.ioc.group.processor
Group GARYI04:FR:FR1:DECODER:PVI defines no +trigger mappings. Default to individual/split monitor updates.
2025-05-29T16:03:23.505121630 WARN pvxs.ioc.group.processor
Group GARYI04:FR:FR2:DECODER:PVI defines no +trigger mappings. Default to individual/split monitor updates.
2025-05-29T16:03:23.505153269 WARN pvxs.ioc.group.processor
Group GARYI04:FR:FR3:DECODER:PVI defines no +trigger mappings. Default to individual/split monitor updates.
GARYI04:EF:PVI: Error Group not created: invalid field name "0_config_acqid"
GARYI04:MW:PVI: Error Group not created: invalid field name "0_config_ctrl_port"
These could potentially be handled in the same logic.
Acceptance Criteria
- These parameters are handled correctly
- Unit tests added to show these parameters are handled
Metadata
Metadata
Assignees
Labels
No labels