-
Notifications
You must be signed in to change notification settings - Fork 5
Open
Description
The values of the start_offset and stop_offset keys have the following constraints:
- can be omitted
- can be
None - can be an
int
The current type for them is Optional[int]:
httomo/httomo/transform_loader_params.py
Lines 34 to 42 in 584e15c
| class StartStopEntry(TypedDict): | |
| """ | |
| Configuration for a single dimension's previewing in terms of start/stop values. | |
| """ | |
| start: Union[int, str] | |
| start_offset: Optional[int] | |
| stop: Union[int, str] | |
| stop_offset: Optional[int] |
which doesn't reflect all those constraints: it misses 1 and 2.
I think the correct type would be NotRequired[Optional[int]].
Metadata
Metadata
Assignees
Labels
No labels