Read detector ID from device (#1526)

* Read detector_id during read_hardware_plan

* Pin dodal

* PR comments and fixes

* Remove unused line

* Pin dodal

* Unpin dodal

Author: jacob720

pyproject.toml

@@ -48,7 +48,7 @@ dependencies = [
     "ophyd >= 1.10.5",
     "ophyd-async >= 0.14.0",
     "bluesky >= 1.14.6",
-    "dls-dodal @ git+https://github.com/DiamondLightSource/dodal.git@62960e0e587bf86943ce1b581848fa131ef884d5",
+    "dls-dodal @ git+https://github.com/DiamondLightSource/dodal.git@main",
 ]
 
 

src/mx_bluesky/beamlines/i04/experiment_plans/i04_grid_detect_then_xray_centre_plan.py

@@ -291,6 +291,7 @@ def construct_i04_specific_features(
         xrc_composite.eiger.bit_depth,
         xrc_composite.beamsize,
         xrc_composite.eiger.cam.roi_mode,
+        xrc_composite.eiger.ispyb_detector_id,
     ]
 
     tidy_plan = partial(

src/mx_bluesky/common/experiment_plans/inner_plans/read_hardware.py

@@ -76,6 +76,7 @@ def standard_read_hardware_during_collection(
         detector.bit_depth,
         beamsize,
         detector.cam.roi_mode,
+        detector.ispyb_detector_id,
     ]
     yield from read_hardware_plan(
         signals_to_read_during_collection, DocDescriptorNames.HARDWARE_READ_DURING

src/mx_bluesky/common/external_interaction/callbacks/common/ispyb_callback_base.py

@@ -124,7 +124,6 @@ def _handle_ispyb_hardware_read(self, doc) -> Sequence[ScanDataInfo]:
         )
         synchrotron_mode = doc["data"]["synchrotron-synchrotron_mode"]
         assert isinstance(synchrotron_mode, SynchrotronMode)
-
         hwscan_data_collection_info = DataCollectionInfo(
             undulator_gap1=doc["data"]["undulator-current_gap"],
             synchrotron_mode=synchrotron_mode.value,
@@ -159,6 +158,7 @@ def _handle_ispyb_transmission_flux_read(
             beamsize_at_sampley=beamsize_y_mm,
             flux=doc["data"]["flux-flux_reading"],
             detector_mode="ROI" if doc["data"]["eiger_cam_roi_mode"] else "FULL",
+            ispyb_detector_id=doc["data"]["eiger-ispyb_detector_id"],
         )
         if transmission := doc["data"]["attenuator-actual_transmission"]:
             # Ispyb wants the transmission in a percentage, we use fractions

src/mx_bluesky/common/external_interaction/callbacks/common/ispyb_mapping.py

@@ -9,7 +9,6 @@
 )
 from mx_bluesky.common.parameters.components import DiffractionExperimentWithSample
 
-I03_EIGER_DETECTOR = 78
 EIGER_FILE_SUFFIX = "h5"
 
 
@@ -31,7 +30,6 @@ def populate_remaining_data_collection_info(
     data_collection_info.sample_id = params.sample_id
     data_collection_info.visit_string = params.visit
     data_collection_info.parent_id = data_collection_group_id
-    data_collection_info.detector_id = I03_EIGER_DETECTOR
     data_collection_info.comments = comment
     data_collection_info.detector_distance = params.detector_params.detector_distance
     data_collection_info.exp_time = params.detector_params.exposure_time_s

src/mx_bluesky/common/external_interaction/ispyb/data_model.py

@@ -40,7 +40,7 @@ class DataCollectionInfo:
     kappa_start: float | None = None
 
     visit_string: str | None = None
-    detector_id: int | None = None
+    ispyb_detector_id: int | None = None
     axis_start: float | None = None
     slitgap_vertical: float | None = None
     slitgap_horizontal: float | None = None

src/mx_bluesky/common/external_interaction/ispyb/exp_eye_store.py

@@ -282,7 +282,7 @@ def _data_collection_info_to_json(data: DataCollectionInfo) -> dict:
             "axisEnd": data.axis_end,
             "chiStart": data.chi_start,
             "kappaStart": data.kappa_start,
-            "detectorId": data.detector_id,
+            "detectorId": data.ispyb_detector_id,
             "axisStart": data.axis_start,
             "slitGapVertical": data.slitgap_vertical,
             "slitGapHorizontal": data.slitgap_horizontal,

src/mx_bluesky/hyperion/experiment_plans/hyperion_flyscan_xray_centre_plan.py

@@ -62,6 +62,7 @@ def construct_hyperion_specific_features(
         xrc_composite.eiger.bit_depth,
         xrc_composite.beamsize,
         xrc_composite.eiger.cam.roi_mode,
+        xrc_composite.eiger.ispyb_detector_id,
     ]
 
     setup_trigger_plan: Callable[..., MsgGenerator]

tests/conftest.py

@@ -1421,6 +1421,7 @@ def test_rotation_event_document_during_data_collection(self) -> Event:
                 "beamsize-x_um": 50.0,
                 "beamsize-y_um": 20.0,
                 "eiger_cam_roi_mode": False,
+                "eiger-ispyb_detector_id": 78,
             },
             "timestamps": {"det1": 1666604299.8220396, "det2": 1666604299.8235943},
             "seq_num": 1,
@@ -1536,6 +1537,7 @@ def test_event_document_during_data_collection(self) -> Event:
                 "beamsize-x_um": 50.0,
                 "beamsize-y_um": 20.0,
                 "eiger_cam_roi_mode": True,
+                "eiger-ispyb_detector_id": 78,
             },
             "timestamps": {
                 "det1": 1666604299.8220396,

tests/unit_tests/common/external_interaction/callbacks/ispyb/test_gridscan_ispyb_store_3d.py

@@ -61,7 +61,7 @@ def dummy_collection_group_info():
     kappa_start=None,
     parent_id=None,
     visit_string="cm31105-4",
-    detector_id=78,
+    ispyb_detector_id=78,
     axis_start=0.0,
     slitgap_vertical=0.1,
     slitgap_horizontal=0.1,