Skip to content

Commit 187eb14

Browse files
authored
Write some new ADRs (#111)
2 parents e47f7de + 5d11830 commit 187eb14

File tree

7 files changed

+85
-39
lines changed

7 files changed

+85
-39
lines changed

docs/explanations/decisions/0001-record-architecture-decisions.md

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
# 1. Record architecture decisions
22

3-
Date: 2022-02-18
4-
53
## Status
64

75
Accepted
Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
1+
# 15. Use ruff
2+
3+
Date: 2024-02-15
4+
5+
## Status
6+
7+
Accepted
8+
9+
## Context
10+
11+
Ruff is faster than flake8 and black, has mostly compatible output, and is gaining popularity.
12+
13+
## Decision
14+
15+
We will switch to using ruff for linting and formatting.
16+
17+
## Consequences
18+
19+
We may have to consider pinning ruff in the future if its output changes regularly.
Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,26 @@
1+
# 16. Convert to mkdocs
2+
3+
Date: 2024-02-15
4+
5+
## Status
6+
7+
Rejected
8+
9+
## Context
10+
11+
Markdown is nicer to write, we have to write using mkdocs for the developer portal and backstage likes it, should we switch to using it?
12+
13+
It can mostly replace sphinx, but there are a few places it falls down:
14+
15+
- The API docs (mkdocstrings) have some paid for features that we already use in sphinx
16+
- The plugin landscape is vast, but not well maintained
17+
- The scientific python community (i.e. numpy, scipy, matplotlib, bluesky) uses sphinx exclusively
18+
- There are custom directives like the ipython one that we would struggle to replace
19+
20+
## Decision
21+
22+
We will stick with sphinx for now, but use MyST so we can write markdown with it.
23+
24+
## Consequences
25+
26+
We will keep an eye on mkdocs.
Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
1+
# 17. Use pyright
2+
3+
Date: 2024-02-15
4+
5+
## Status
6+
7+
Accepted
8+
9+
## Context
10+
11+
Pyright is faster than mypy, and catches more errors.
12+
13+
## Decision
14+
15+
We will use it by default, but retain mypy as an option for existing projects where pyright gives too many errors to quickly migrate.
16+
17+
## Consequences
18+
19+
We will add a new question to let people switch between the two.

docs/explanations/decisions/COPYME

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
1+
# 3. Short descriptive title
2+
3+
Date: Today's date
4+
5+
## Status
6+
7+
Accepted
8+
9+
## Context
10+
11+
Background to allow us to make the decision, to show how we arrived at our conclusions.
12+
13+
## Decision
14+
15+
What decision we made.
16+
17+
## Consequences
18+
19+
What we will do as a result of this decision.

template/{% if sphinx %}docs{% endif %}/explanations/decisions/0001-record-architecture-decisions.md

Lines changed: 0 additions & 18 deletions
This file was deleted.
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
../../../../docs/explanations/decisions/0001-record-architecture-decisions.md

template/{% if sphinx %}docs{% endif %}/explanations/decisions/COPYME

Lines changed: 0 additions & 19 deletions
This file was deleted.
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
../../../../docs/explanations/decisions/COPYME

0 commit comments

Comments
 (0)