Skip to content

Commit 1cbfff0

Browse files
author
Ware, Joseph (DLSLtd,RAL,LSCI)
committed
docs: Add ADR for ci on PR only
1 parent 75ab007 commit 1cbfff0

File tree

1 file changed

+24
-0
lines changed

1 file changed

+24
-0
lines changed
Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,24 @@
1+
# 21. Run CI on pull requests and main branch only
2+
3+
Date: 2025-05-06
4+
5+
## Status
6+
7+
Accepted
8+
9+
## Context
10+
11+
CI has been being run on branches that do not have open pull requests, which has: added spurious jobs to the organisation's compute limit; made workflow definitions more complex; made the results page harder to parse; and allowed known working development branches to become stale or forgotten.
12+
13+
Running CI only on branches that have open pull requests will: reduce compute jobs created for code that is known to not be working; simplify workflow definitions; simplify the CI results page; encourage early creation of pull requests, adding visibility to development.
14+
15+
Draft pull requests will still have CI jobs run, ensuring that code quality is maintained while allowing reviewers to ignore changes that are not ready for human review.
16+
17+
## Decision
18+
19+
CI will only be run on all PRs when changes are made, and on the main branch when PRs are merged into it: not on branches that do not have open PRs.
20+
Opening a draft PR will allow CI to be run, with the understanding that the PR may not be ready for review.
21+
22+
## Consequences
23+
24+
The `check` job will be removed and CI will run on all PRs and on the `main` branch.

0 commit comments

Comments
 (0)