Skip to content

Commit 6a402b1

Browse files
committed
Fix conditional on pypi, release and dist workflows to rely on tests passing
1 parent 2e9f1fa commit 6a402b1

File tree

2 files changed

+3
-3
lines changed
  • .github/workflows
  • template/{% if git_platform=="github.com" %}.github{% endif %}/workflows

2 files changed

+3
-3
lines changed

.github/workflows/ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ jobs:
4040
EXAMPLE_DEPLOY_KEY: ${{ secrets.EXAMPLE_DEPLOY_KEY }}
4141

4242
release:
43-
if: github.ref_type == 'tag'
43+
if: needs.test.result && github.ref_type == 'tag'
4444
needs: [test, docs]
4545
uses: ./.github/workflows/_release.yml
4646
permissions:

template/{% if git_platform=="github.com" %}.github{% endif %}/workflows/ci.yml.jinja

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ jobs:
4949
{% endif %}
5050
dist:
5151
needs: check
52-
if: needs.check.outputs.branch-pr == ''
52+
if: needs.test.output && needs.check.outputs.branch-pr == ''
5353
uses: ./.github/workflows/_dist.yml
5454
{% if pypi %}
5555
pypi:
@@ -60,7 +60,7 @@ jobs:
6060
id-token: write
6161
{% endif %}
6262
release:
63-
if: github.ref_type == 'tag'
63+
if: needs.test.output && github.ref_type == 'tag'
6464
needs: [dist, test{% if sphinx %}, docs{% endif %}]
6565
uses: ./.github/workflows/_release.yml
6666
permissions:

0 commit comments

Comments
 (0)