Different way of patching

Author: stephen-riggs

src/murfey/server/ispyb.py

@@ -124,7 +124,6 @@ def do_insert_data_collection_group(
         **kwargs,
     ):
         try:
-            print(ISPyBSession())
             with ISPyBSession() as db:
                 db.add(record)
                 db.commit()

tests/server/test_ispyb.py

@@ -72,7 +72,12 @@ def test_get_all_ongoing_visits():
 
 
 @mock.patch("workflows.transport.pika_transport.PikaTransport")
-def test_update_data_collection_group(mock_transport, ispyb_db_session: Session):
+@mock.patch("murfey.server.ispyb.ISPyBSession.__call__")
+def test_update_data_collection_group(
+    mock_ispyb_session_call, mock_transport, ispyb_db_session: Session
+):
+    mock_ispyb_session_call.return_value = ispyb_db_session
+
     # Manually get the BLSession ID for comparison
     bl_session_id = (
         ispyb_db_session.execute(
@@ -99,10 +104,9 @@ def test_update_data_collection_group(mock_transport, ispyb_db_session: Session)
     )
 
     transport_manager = TransportManager("PikaTransport")
-    with mock.patch("murfey.server.ispyb.ISPyBSession.__call__", ispyb_db_session):
-        transport_manager.do_update_data_collection_group(
-            record=DataCollectionGroup(dataCollectionGroupId=1, experimentTypeId=2)
-        )
+    transport_manager.do_update_data_collection_group(
+        record=DataCollectionGroup(dataCollectionGroupId=1, experimentTypeId=2)
+    )
 
     final_dcg_entry = get_or_create_db_entry(
         session=ispyb_db_session,