Skip to content

Commit 35d82aa

Browse files
authored
Move auth_url from machine configuration to security configuration (#589)
1 parent 368dd2f commit 35d82aa

File tree

2 files changed

+3
-9
lines changed

2 files changed

+3
-9
lines changed

src/murfey/server/api/auth.py

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
from __future__ import annotations
22

3-
import os
43
import secrets
54
import time
65
from logging import getLogger
@@ -19,7 +18,7 @@
1918

2019
from murfey.server import sanitise
2120
from murfey.server.murfey_db import murfey_db, url
22-
from murfey.util.config import get_machine_config, get_security_config
21+
from murfey.util.config import get_security_config
2322
from murfey.util.db import MurfeyUser as User
2423
from murfey.util.db import Session as MurfeySession
2524

@@ -64,12 +63,7 @@ async def __call__(self, request: Request):
6463

6564
# Set up variables used for authentication
6665
security_config = get_security_config()
67-
machine_config = get_machine_config()
68-
auth_url = (
69-
machine_config[os.getenv("BEAMLINE", "")].auth_url
70-
if machine_config.get(os.getenv("BEAMLINE", ""))
71-
else ""
72-
)
66+
auth_url = security_config.auth_url
7367
ALGORITHM = security_config.auth_algorithm or "HS256"
7468
SECRET_KEY = security_config.auth_key or secrets.token_hex(32)
7569
if security_config.auth_type == "password":

src/murfey/util/config.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,6 @@ class MachineConfig(BaseModel, extra=Extra.allow): # type: ignore
6868
rsync_url: str = ""
6969

7070
security_configuration_path: Optional[Path] = None
71-
auth_url: str = ""
7271

7372
notifications_queue: str = "pato_notification"
7473

@@ -88,6 +87,7 @@ class Security(BaseModel):
8887
crypto_key: str
8988
auth_key: str = ""
9089
auth_algorithm: str = ""
90+
auth_url: str = ""
9191
sqlalchemy_pooling: bool = True
9292
allow_origins: List[str] = ["*"]
9393
session_validation: str = ""

0 commit comments

Comments
 (0)